From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48B8D41C95; Tue, 14 Feb 2023 14:12:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F86D410EF; Tue, 14 Feb 2023 14:12:26 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2081.outbound.protection.outlook.com [40.107.237.81]) by mails.dpdk.org (Postfix) with ESMTP id BC2A1410D1 for ; Tue, 14 Feb 2023 14:12:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GTPtctY2KuhM3hc1EpF9XC8k6XQLQnbGXB1w8oMZ/yhhPNMmulnSShpa4PNPpI97zFt28PtUYmv6LbdzseoLEbS1VlZ15LtLwQaNKHdBKw81Pq9BrmO5PJt9k2DSD1SeiAb9IVH6/2id2wSgd1z62ts6C5ouyVyfasnk3S/tY3jjXJO1/dB/sF+xFzCeXzkK0Zm2UcISHq8Bm8zWZKiYLCiSimygR7RpnuEquU3AxQGJIhoKyQ9dvftMkI5+iQCb4FXRT7pW1DExhrzoyDUyAEYtmkSB13dHtA7pc7o1eFHxwzuwjV9yn6irmEAcz2bqZmuL7fCfLFpRuLaBkAAN2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZEHqF7VNfrfg/XOVkOyzTuNYWhWPn9tJsZAKKM/apQo=; b=Iujmxz3xI2GrxnrYro1Qlip8wZldHAMVhaHGPrlCAx5yvtAhHt073vanRfAI1xYJe9tyxrYhHLStshBYLVuJneJlEfSbAyReczkaz/i7RE/nx0vX/Uo9TzAojpusE11kv1/LQtqHeDPMczWE5Z+ArQp53/JsVLKSnVzkXUd1neacPcO+VMkxGiHyg7oY6JMEBOgXoUStykgFQm9/F+M7Tvl3Xguzu2W0NMabOdxqcvWlS5leYcTyNdAqkI9jpkLv/oqYMCaHtP3pY92qohMWETDmVSM8/UFapbDAP6oUc/5D3lyPUDoNV3vdNl/fx3ugrz03rFKGGsJOPhdZC3f6Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZEHqF7VNfrfg/XOVkOyzTuNYWhWPn9tJsZAKKM/apQo=; b=hHJwzC2ZINlL9D3wnp/MZ0eAobGDOBqNFEkek0nDsCnaC6D2lmLdGNH7g1KuRPPhDHdBBioft3+PLfkfja4i3tDUvbUDMcrxXHyjTTw69/gdTetSLjT27yau2NpDuG4YJZGUqN45OBA38trxcFgHzq53pAjAjllq8Nym+fj5w1M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB6877.namprd12.prod.outlook.com (2603:10b6:a03:47f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Tue, 14 Feb 2023 13:12:22 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6086.026; Tue, 14 Feb 2023 13:12:22 +0000 Message-ID: <67c958be-09e7-5c70-9a59-d471daeab4e8@amd.com> Date: Tue, 14 Feb 2023 13:12:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v6 2/3] app/testpmd: add skip cman support for testpmd Content-Language: en-US From: Ferruh Yigit To: Rakesh Kudurumalla , Ori Kam , Aman Singh , Yuying Zhang , jerinj@marvell.com Cc: ndabilpuram@marvell.com, dev@dpdk.org References: <20230210081422.1004901-1-rkudurumalla@marvell.com> <20230210082623.1005496-1-rkudurumalla@marvell.com> <20230210082623.1005496-2-rkudurumalla@marvell.com> <8e70d8e9-ed7d-337b-205c-b6ee32e5cc48@amd.com> In-Reply-To: <8e70d8e9-ed7d-337b-205c-b6ee32e5cc48@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0119.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB6877:EE_ X-MS-Office365-Filtering-Correlation-Id: 59e80c7a-3077-4cb2-6c1d-08db0e8d1bdd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4oEF4x924XT2JoHaQYNbE6GT9n2fDultyzKwfHOUqfmNzQAS/vFeRkRQKqUH9vlyxJBz4+a2aLQi6mAkqKuHsK7BvktBPGLdd5pZyd4v2BYU17OpaU5E+zQWnDgujxhnXQD2ith2VASufwX67JLr9bdQZ8aPM9uivYC7V/8aFcpKE7vIe+d2fTOcXKICuSFWFvGgJrPkgSRsMHF0zeOHYtji315KrP7B6PEOk4nwdBgS7cJDez9alvGVT1IF0dO/0XXqV7kvVzd9NuO/4Ohfsit5nKApCR67Sw6HMiJd1jNxnMRuxjTQEsaNphAePbMICW/TLvIc6zsTMaIX9QCa4Nn10OyzHWej7NXZ0QWyP2PJcfCx7BGvZL7tdK3226gI9AUe7NKHWJ653oFhp2Sx8WGi/QHPtkZQQj9y4oW8bdGGCfcWE6++n3DpMf4IYZEBWI3G/PhPRP+scARtPb0IGfRxT2MOQvXA3AmeCiF1JaJEqBIHymkDQBZqyx90spfhJnG0D+CryxknPiZuHsLuTkCFM5DB5CnaI+Sz4A0eWZ9H8yY6+hicjZhL9GpTvJ+a5gT/Lm5TGpVLO857v7cWmsHN6z9rj/6f1r+S6TDTg4Cw1ay6dNP0hkShONY7LcDomL/sd3uCvu4eG6RCWAykK5iZgsj/AzM41LHhxVc4xylEXicUmcIC+R+ZcGf2J+J8Rj8guua5m+hBFXcPIBQaHT0fAsEFP9+ClyhZWy1hQKc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(39860400002)(366004)(136003)(396003)(346002)(451199018)(83380400001)(5660300002)(41300700001)(44832011)(8936002)(38100700002)(86362001)(36756003)(31696002)(2906002)(316002)(110136005)(6506007)(53546011)(31686004)(26005)(6512007)(186003)(4326008)(6666004)(966005)(478600001)(2616005)(6486002)(8676002)(66476007)(66946007)(66556008)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFJaK3kzL3ZKK0lWQkxiQ3JySVZkOUxrbUo2SVg1Mzh3SnZwRGNneS9uN3NG?= =?utf-8?B?S1hqUHFPWGNQaGVEYWlzMURvSkozS0RtZVRUQU5kM3NEVk9sUVIrMUVtSHYv?= =?utf-8?B?WEVnTENua2k5NDZHdERYUXgvMzlMa2hTV3J4cXBWUEg2NFVxdXRKMVFxM3VI?= =?utf-8?B?eWJ3SEpyM21RdEhBZ0xrZitWdVhKcERQVXNCY2RGdnhIc0RudGI3OGE0Sk53?= =?utf-8?B?U3FxKzhjM05acEhPaDVmTUhWMDZYTFdGNk1YeFAwdWlweEJXbFRTOWd5T0Iw?= =?utf-8?B?eXVqQ2xtUUlPMmlpSGoxRkpKMEFoK1N2U0pGK09LcDd6UkplbmRtd3p6THBo?= =?utf-8?B?RkEzUDkzelNpRnVEcHlKQmNqS1E3aC9LRG5wcUdNOXJNeUpKbmdzNTlwUGdV?= =?utf-8?B?TURXMDY3VWpaMnlKQ1Y1Szh2MUdhVlpub3A4ZDllMElEWjFZTS9XaDNoblpC?= =?utf-8?B?VGtGY1hOOEFTWFBiMHY2c25yL1FlVk9WZ2Fid0o3S2YvNGxYaEZRR2d4WUlG?= =?utf-8?B?Z04xeVpHZSs3eVNoY2lVREc5b1pEUnVPVXppc0IwK09UcEpSSWJ4Z0RBYlVE?= =?utf-8?B?ME1CL3hvV2xCNDd4SmN4Qjc4ZE1aQzhjTUdlaTY2K0UvWWxUTEpzQm9NWk5B?= =?utf-8?B?dTBpSTdBenF3MGZOVzdVZzY4bzZkdExyQWU2K1djUnpLZUEvcE0zYXRQQlEz?= =?utf-8?B?UFg4QkxTRHhhbTFzNCtSWjdRZnJ5UGZ1TVBTNUlIclRBT3l5bmRaZFhCbC93?= =?utf-8?B?N010cFJnS3lqdzk0V2kyUHd1ckM4QitRVHBLMW84V01GWnREZGZTTjFHdGhW?= =?utf-8?B?ZVZOWXRvM2MrdC81UHRyOHNYRVp6WS9sTTIxekxsTndFZS9sRnRLZGkvd2Nh?= =?utf-8?B?bXR3cjFMTExvWmJVdHd3VTVBZVp4ajVWcms0cnVzNzZvU2lzNFRCRzZEYWhz?= =?utf-8?B?NVEvVlJvZ0dMR1VhTXJrdkpUWFFodkRBVmk2Y25nV1JBOEV2a3pZYlU1OFFl?= =?utf-8?B?WjhMaVJieUpqc2NOMEhUOWNzM09tVWtlYmNhRFZXbnNtbWJJTlREU0FyZ0tU?= =?utf-8?B?eU1nRGRBVWcwdFFVZ2hZY3lPenVmd1EvVVZtWTBrWjFlQlNHNElYc3p3d3lN?= =?utf-8?B?UFBhbWgxa2gyQUx4NkVtR1gwYjVBV3F1YU80aDdPYnRNbkJqdlBlME95ZmRD?= =?utf-8?B?OUN4dGVSMVpqNUxsVTRaamRpc05pWDBQY3JrejZsamVDVnpXQ01nQkVOU0My?= =?utf-8?B?VWxTSmRoL0ZiN0RHSHNIZWgrZGRRdVBGWFMyMDVBOGVBK3NmV2p0eFAralRT?= =?utf-8?B?d3RrWHYwMmw2VE9yaFhEb0wrcUh2OERJU3g3aVJ5NGNPcVBHbS9EMW41ejJs?= =?utf-8?B?TTRYc2tydi9YKzdnL0FOUEp1cUNvOGpZdXNFUUdtNEpiTlRyejRJb3VxMXVD?= =?utf-8?B?UXh5aUNrdkR3Q0ZLMUhSNmV1QkEybWRuM0JtQURjRXBYNEFneW5vZTkyOVdp?= =?utf-8?B?MjdvY2hsa2tzSjR6VUFhS1N0eFA3cm9adGdpVyt3aTBpbUdIdkF2cHRyaGF0?= =?utf-8?B?OE9BTnN6YkZHTmpUc05nbDRFWWQ0VlBJbjlvaHh3NWFZT3ZzdHpFZmxVenBB?= =?utf-8?B?ZWlVM05KVkthcWZTekIzVlh2OUNCQ2ZmT3p6WnY3VTIwbU90S1FKUmlkQjVR?= =?utf-8?B?NXVGMml1eDhMQkdYTE1PVHBQRVNuSnBia2MzY2Y1TDlSYzQ0TlZ2bGVJNDE0?= =?utf-8?B?c2FxT2l3aUg3d1NkNDdYdG9tb1lrL0VxQ2UvYjBndVhaRW1LK1VtOUhRZnc0?= =?utf-8?B?M2Y5WWluUkQ3bDBzdWoyK2VNTmh1RHRXRithOTcyMEFwUE9UU1kraW1aa3Zq?= =?utf-8?B?bEJNNC9Ld1l3MVR1akMzVnJQZFVXUmxQVlZmT0sxVXdTQ05hYkRCZy9FTUln?= =?utf-8?B?NlFHVG9sZXJoSVlCSnd5ZmdCV0dRZ1d4Wnh5Q2RhSThtOXlscmRNb2lMaVl1?= =?utf-8?B?TGhXOUZNSGtSRVhjUHdUZEVzM2krQVoremtMR3ZrVUIxQklleXhSV29vSGxD?= =?utf-8?B?ZzQxS2VzUlRKeWR4a1doNUtGTnd4a09vK1BQalRNNnFJU0xGdDVUVU5BS1R4?= =?utf-8?Q?xuJYCu3wWRWVvsDGhNDSxeWGW?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59e80c7a-3077-4cb2-6c1d-08db0e8d1bdd X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 13:12:22.6855 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ap7QPN1pTi9Ymh2URw9mFAauOfZpWZhkqOw47MkT1e57ooYPAfpk7UaXRfXK5Aj9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6877 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/10/2023 11:08 PM, Ferruh Yigit wrote: > On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: >> added support for testpmd application to accept >> skip_cman action while configuring policy action >> > > Can you please give some sample testpmd commands with new action in > commit log, it helps. > reminder of this comment, v8 doesn't have this. please check following as sample: "app/testpmd: add shared indirect action support" https://git.dpdk.org/next/dpdk-next-net/commit/?id=c13f2654cd3c67e526be0 >> Signed-off-by: Rakesh Kudurumalla >> --- >> app/test-pmd/cmdline_flow.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c >> index 88108498e0..fc003e0096 100644 >> --- a/app/test-pmd/cmdline_flow.c >> +++ b/app/test-pmd/cmdline_flow.c >> @@ -472,6 +472,7 @@ enum index { >> ACTION_END, >> ACTION_VOID, >> ACTION_PASSTHRU, >> + ACTION_SKIP_CMAN, >> ACTION_JUMP, >> ACTION_JUMP_GROUP, >> ACTION_MARK, >> @@ -1825,6 +1826,7 @@ static const enum index next_action[] = { >> ACTION_END, >> ACTION_VOID, >> ACTION_PASSTHRU, >> + ACTION_SKIP_CMAN, >> ACTION_JUMP, >> ACTION_MARK, >> ACTION_FLAG, >> @@ -5159,6 +5161,13 @@ static const struct token token_list[] = { >> .next = NEXT(NEXT_ENTRY(ACTION_NEXT)), >> .call = parse_vc, >> }, >> + [ACTION_SKIP_CMAN] = { >> + .name = "skip_cman", >> + .help = "bypass cman on received packets", >> + .priv = PRIV_ACTION(SKIP_CMAN, 0), >> + .next = NEXT(NEXT_ENTRY(ACTION_NEXT)), >> + .call = parse_vc, >> + }, >> [ACTION_JUMP] = { >> .name = "jump", >> .help = "redirect traffic to a given group", >