From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2182A00C2; Thu, 13 Oct 2022 10:02:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50B7D42D90; Thu, 13 Oct 2022 10:02:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 914F242C27 for ; Thu, 13 Oct 2022 10:02:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665648128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P+eHne8bTDFtSKpGuh8EerTFNvRLG19CnVXPW4Yad2Q=; b=TXfcJZpftKLQkO0iVUmI2fQYh34XNhoZZ1jURtFqs9QQ2JjviWczHNJhJ1KR3jR1Ro41fh nY2JfMMguEmDveVx/ICrOLPhxqp0iBQngs+iH1oZOY86tWUv+NR42Q83i2HCxjS5w2rGnM S+YGbQQ1EzDkJCktoY1hX5m3J+L8qIA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-7-HCimBEB2NeaAnjFHqjyQbQ-1; Thu, 13 Oct 2022 04:02:03 -0400 X-MC-Unique: HCimBEB2NeaAnjFHqjyQbQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 240031C07560; Thu, 13 Oct 2022 08:02:03 +0000 (UTC) Received: from [10.39.208.28] (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6BC9AC15BB9; Thu, 13 Oct 2022 08:02:01 +0000 (UTC) Message-ID: <67ed0549-0867-35ef-571a-1e339aec4797@redhat.com> Date: Thu, 13 Oct 2022 10:01:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v4 1/2] vhost: introduce DMA vchannel unconfiguration To: xuan.ding@intel.com, chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, xingguang.he@intel.com, yvonnex.yang@intel.com, cheng1.jiang@intel.com, yuanx.wang@intel.com, wenwux.ma@intel.com References: <20220814140442.82525-1-xuan.ding@intel.com> <20221013064040.98489-1-xuan.ding@intel.com> <20221013064040.98489-2-xuan.ding@intel.com> From: Maxime Coquelin In-Reply-To: <20221013064040.98489-2-xuan.ding@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/13/22 08:40, xuan.ding@intel.com wrote: > From: Xuan Ding > > Add a new API rte_vhost_async_dma_unconfigure() to unconfigure DMA > vchannels in vhost async data path. Lock protection are also added > to protect DMA vchannels configuration and unconfiguration > from concurrent calls. > > Signed-off-by: Xuan Ding > --- > doc/guides/prog_guide/vhost_lib.rst | 6 +++ > doc/guides/rel_notes/release_22_11.rst | 4 ++ > lib/vhost/rte_vhost_async.h | 18 +++++++ > lib/vhost/version.map | 3 ++ > lib/vhost/vhost.c | 69 ++++++++++++++++++++++++-- > 5 files changed, 95 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst > index bad4d819e1..d3cef978d0 100644 > --- a/doc/guides/prog_guide/vhost_lib.rst > +++ b/doc/guides/prog_guide/vhost_lib.rst > @@ -323,6 +323,12 @@ The following is an overview of some key Vhost API functions: > Get device type of vDPA device, such as VDPA_DEVICE_TYPE_NET, > VDPA_DEVICE_TYPE_BLK. > > +* ``rte_vhost_async_dma_unconfigure(dma_id, vchan_id)`` > + > + Clean DMA vChannels finished to use. This function needs to > + be called after the deregistration of async DMA vchannel > + has been finished. > + > Vhost-user Implementations > -------------------------- > > diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst > index 2da8bc9661..3be150122c 100644 > --- a/doc/guides/rel_notes/release_22_11.rst > +++ b/doc/guides/rel_notes/release_22_11.rst > @@ -236,6 +236,10 @@ New Features > > strings $dpdk_binary_or_driver | sed -n 's/^PMD_INFO_STRING= //p' > > +* **Added DMA vChannel unconfiguration for async vhost.** > + > + * Added support to unconfigure DMA vChannels that have been unregistered. > + > > Removed Items > ------------- > diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h > index 1db2a10124..6ee4f7258d 100644 > --- a/lib/vhost/rte_vhost_async.h > +++ b/lib/vhost/rte_vhost_async.h > @@ -266,6 +266,24 @@ rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id, > struct rte_mempool *mbuf_pool, struct rte_mbuf **pkts, uint16_t count, > int *nr_inflight, int16_t dma_id, uint16_t vchan_id); > > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice. > + * > + * Unconfigure DMA vChannels in asynchronous data path. > + * This function should be called after the DMA vChannel has been unregistered. > + * > + * @param dma_id > + * the identifier of DMA device > + * @param vchan_id > + * the identifier of virtual DMA channel > + * @return > + * 0 on success, and -1 on failure > + */ > +__rte_experimental > +int > +rte_vhost_async_dma_unconfigure(int16_t dma_id, uint16_t vchan_id); > + > #ifdef __cplusplus > } > #endif > diff --git a/lib/vhost/version.map b/lib/vhost/version.map > index 7a00b65740..0b61870870 100644 > --- a/lib/vhost/version.map > +++ b/lib/vhost/version.map > @@ -94,6 +94,9 @@ EXPERIMENTAL { > rte_vhost_async_try_dequeue_burst; > rte_vhost_driver_get_vdpa_dev_type; > rte_vhost_clear_queue; > + > + # added in 22.11 > + rte_vhost_async_dma_unconfigure; > }; > > INTERNAL { > diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c > index 8740aa2788..9fbc56229a 100644 > --- a/lib/vhost/vhost.c > +++ b/lib/vhost/vhost.c > @@ -23,6 +23,7 @@ > > struct virtio_net *vhost_devices[RTE_MAX_VHOST_DEVICE]; > pthread_mutex_t vhost_dev_lock = PTHREAD_MUTEX_INITIALIZER; > +static rte_spinlock_t vhost_dma_lock = RTE_SPINLOCK_INITIALIZER; I think a mutex would be more appropiate. Thanks, Maxime