From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Santosh.Shukla@cavium.com> Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0077.outbound.protection.outlook.com [104.47.41.77]) by dpdk.org (Postfix) with ESMTP id 966DF235 for <dev@dpdk.org>; Wed, 20 Sep 2017 12:25:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jHe0fAtQT35cIdFssz4NWivLXlYGnbN/DcN6fM5fReU=; b=hIogJPQPGaZ2cXyy1PCTRupuzAnHEYuoTnmSy21QNP/myhgHpEENCen1nQx7lrhEOOiHkXo+/p3tmYdwuWnrQGLVjgChJTArkxikGQ/4YFHLAyuHXzBm/u2mi7x6/G4SIHrGnRZTix6zmmWBVQ3RP7rOqYNrQ9y+Fe3yWkvp9p8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [192.168.1.100] (223.180.5.4) by BN6PR07MB3089.namprd07.prod.outlook.com (10.172.105.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Wed, 20 Sep 2017 10:25:02 +0000 To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org References: <20170831032618.7120-1-santosh.shukla@caviumnetworks.com> <20170918104234.9149-1-santosh.shukla@caviumnetworks.com> <20170918104234.9149-3-santosh.shukla@caviumnetworks.com> <92424c77-29d5-4e4e-7f53-22c015d24fb3@intel.com> <345a32cc-7a22-ea86-78f9-131404a2642b@caviumnetworks.com> <80e535d6-f412-347e-99a9-9fb2f805551d@intel.com> From: santosh <santosh.shukla@caviumnetworks.com> Message-ID: <67ef2b13-8457-610f-5b68-96b775f5ec61@caviumnetworks.com> Date: Wed, 20 Sep 2017 15:54:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <80e535d6-f412-347e-99a9-9fb2f805551d@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [223.180.5.4] X-ClientProxiedBy: MA1PR01CA0096.INDPRD01.PROD.OUTLOOK.COM (10.174.56.140) To BN6PR07MB3089.namprd07.prod.outlook.com (10.172.105.7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7f3e5a6-1aaf-4cb1-ffa4-08d50011db38 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN6PR07MB3089; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3089; 3:6UMV3+rMR90ONq3JZoAKcICWh7PYPIMuglajNJ9OBBVnme1Kh1E30RjuyS5SCJpv/cX0bl0jMTOImZzw0HASFcBkw0zoYoMYF/bTIN/O0mxdEkiqan2pYB7QHDHbxupF1TGjxAezHKRkJy6f8MITGtUClVDn8sO2XNyg0PYL14SdiYBngnwGNORdGUOLqUy5e8sp+CNXKpFgwGGXibd4pm/YWZ6K7oA1SNCpDGTK1uBzofbIp0KStzEYzHSvA2yQ; 25:v5WHkUHx4g0Tem2VLvGqecYpExfuG3dS8U8L6yGdtRpizzGwDhG2q7mRU7Bag8PuxL0rs47gQfc/4+eHFVZqB6BRMMDAvRGBccEV4Uilvx+KQrlLtK5Bjm77X4lCPFXMgx0Jx2LwmOg6G0eGK082mfFiLJvV2j9puaKMZjebfKd7bBSiBIKqsjS9v0yyiaNaEZJ9LpJQ781kxdvpIHdtkdfK3v7qGqgCCo0nchQ56Ed4XgYboHn4wTk9KePIFgv4Arfmc1SFBxFoRnZQ0Nr+ucA1shCDqbmBExrH8Puy6IcB7YQr8h6Z3u/0a4oK+u6lLh29T2dLsokSucaCw5LU4w==; 31:2nO9Ezv+3AyzpyCyTErfA62+ikNMK85yXQ68DGT/P//PzAihKmLIaniN5ARMLGnHDof0Befg4+Y/xE2+S/SQUPMBL+uzgI/QgHHWIduECPBkc8czZc9FbdQ2KYrH+4kUkB+SoVIK8wwT2t/PBkM6ix5v//NoDO2DkC5CofwIsEDKzGbiYv2zh3VTxMC8J1lEfvv1JbnWCweNNONmygoBkKWTjasS+pB0BrjQl6KzsOk= X-MS-TrafficTypeDiagnostic: BN6PR07MB3089: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3089; 20:Ewhp6SzxCHqTAW/a3zB0RGYmRwlaOGwKUXl4FX8XOJ6Km9u6D5M8Ot4A9uFB8AjfcAIUnyVfWeskjgdSmuZQRnFE1QiOOCZTKNfOBND8ttSwXevaXiir3Q8t5j3RplA5wl1fBdwUo8MTTJJN4J3ALOMIHWzgtgkbIV0VYmn5KMS7dIvRysOo1fZ7NSfGa1OTRyc61K+fuLzMun2nsht248tU8qpAdC+rixeb2eNwACCdrAEGBj122JV3pyD18kHWfwzutFpaAoST1kt1YYFY0PdLIy7u5wfe+qXDSK0jhoegn4hIGpuAHCyvSz17Z3kbHwUV73WrKxqON9zmypo+VfFvNR9K2rs4FZLDLm0kQlHaP6qz4VwWoIMkcb+Vd55AqyJ9zk1ovCg65aiNx5q6W8RmsH5duqBDoZoZ3hckATCE64ILJgQ/H9JbeksVIdyqawstsjVly8iKR+g3Mja97WN7VY98XkECz8zTD65Y5Bx852XsZVXgx2gnNeLeznEZjngprwZK18Bz8NSGL2erhqXMkDlrjggCO1pLxn5BlTMrI1HlGNV4E62x9aA1H2Qi+37uIKh1mLUry95RC+6ozlcelrsawfE1QGJ2CsF27cE=; 4:ihKgeB2jYJaO+xKE35/e7CA/r9YqEZYTfKDo8Foybovwpd2WsbZPN1pSFuUgUktOTp3Yfibb3KTSWzYMBgG0E1bMr7RrQT77SXxAjUiIggdVva3kBIxIGSrNbihRXYebtJAtzcoZRLTiWrB6R5nydYX/vJdx3qRpqMfcKno7A7rjPQN/FuTPGtZjdDxOevCobN+UrNcP0itZUTIw0FBgQnENbEeo48d2+l5NyCZzSIgZMefkB2F6Qk1tPxmIPQYQl4NJpaIAtvdmE9VJJqJiNJ1Su2fxNPJ5M0K+vRfEgtw= X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Microsoft-Antispam-PRVS: <BN6PR07MB308925FF5E44753235DACB81EA610@BN6PR07MB3089.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(6041248)(20161123555025)(20161123560025)(20161123558100)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3089; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3089; X-Forefront-PRVS: 04362AC73B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(376002)(346002)(189002)(199003)(377454003)(24454002)(117156002)(229853002)(53936002)(25786009)(230700001)(23676002)(105586002)(76176999)(31686004)(106356001)(68736007)(58126008)(189998001)(316002)(16526017)(16576012)(33646002)(50986999)(54356999)(6486002)(77096006)(90366009)(64126003)(47776003)(93886005)(2950100002)(42882006)(97736004)(8936002)(8676002)(50466002)(81166006)(66066001)(65956001)(81156014)(65806001)(5660300001)(65826007)(478600001)(2906002)(6116002)(3846002)(6666003)(101416001)(36756003)(83506001)(86152003)(7736002)(72206003)(6246003)(31696002)(53546010)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3089; H:[192.168.1.100]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjA3TUIzMDg5OzIzOnl4ODBhcjJQY2tyS05mNFpHWXZGRnY4WGYy?= =?utf-8?B?TENxK1pGNnFVNlJNVlEwSlhRZUU4dlBDUXBidXlYeDVQbkJzTUtwUkxTcjRa?= =?utf-8?B?YVdhSEhrQnp3TFU0ZTFjK2pSZGFQZXNlN3BWc1lNTUJ1RFFzUi81L1JXcTF6?= =?utf-8?B?K1Y3b2s5MDJOVFJZdTk3TU1Hb2pJZ3hXTEhSWEZodDNsdi9aTUVvdHFWc1Ix?= =?utf-8?B?aTRXSmxIM1hrUEN3ZzM1Y1NsdlRhUUFxejNLUllmODFMQ2FjbnNQYTlGL25I?= =?utf-8?B?VXdIWW11VXB6bTNVeEZNV25VNFF1Yi9VMTZnSElEVXlkQ01kNldVK0JwMjFh?= =?utf-8?B?TGxqdXlIR0ZEQmU5L3FyWDJOQzdseWN4akZLSjd0NEFUTGdBQUxQTzF5QnRW?= =?utf-8?B?QjMrWUFhWVNNUk1MdG92ellwSURTNmZ3NUttSW5VSkJUb29Rekk5L3M1bmlY?= =?utf-8?B?MjdnL2J4c1lzbXc0N2UxczRvZnQyMlZKWWcreHMvTldrNnJTYTF2Y0ZEOTds?= =?utf-8?B?RnAxUm1oM1I3OUpmOVRHUFF3UFd0L09YOTlLNDNUSHpDU2FodVdpV0Nxdmxu?= =?utf-8?B?MkEvRXBTSWZsdUthV1IxTFI3NjZIS2FQeFNzYjZYV2M3Zkh5aXpsMEE5WXg2?= =?utf-8?B?Zm9oelZwTWd3U21kcFRJcElLUm9HKzhxNm54UnVDWlNNYTk5bzErWks0OWFH?= =?utf-8?B?VmVGNHY2VDI3NXJZb2tURkRGYnlVZHhLTVplTUVPRVE4N2VIYTdpUWlsU2lB?= =?utf-8?B?cFF0L0JhYWI3RGFrMFFmZkJUYUNqOTViRW5DekVvZmwwNFMwVzVsL2c2ZXZM?= =?utf-8?B?bXlFMGZ5bVNQT2M5ZTQwSFl6cjVRUFd1MjVKbmZHdDZDcXFpSkluRzBhQUcx?= =?utf-8?B?MGl6R1hLL1E1aHpRak5JcXVzNlk5YnpvckdLeS9CWEc2VHpCSFNqUnc3N1p3?= =?utf-8?B?elZNVGFiY1p3UnMvR1FNcWRCR0YvTkorUjY0M0JjZDBMcFU0V0JxajZLOTVa?= =?utf-8?B?b2ZIeFNTK3l6ZmlMSDhscmlRdlZQazNxYWt0R2VXWWtrSFJZeEtXN2J0N0JZ?= =?utf-8?B?M0kyc3BVYUlHeHowTkV5S3E0a3VOYXBwcXMvOENOZHA1R1RHc1BJa3J0cmsz?= =?utf-8?B?NWQ5cmJyQ29EcWw1OThIWk9hWVMyelpLVjY2WXNMUGlqbnhxSTVyM2dqNjQx?= =?utf-8?B?WHdMU3JlVTA1aldFYWc4Qk5PbWZBUTlkWG0xcGVZajAxbGdJbjE4bENJZ3Qw?= =?utf-8?B?eHp6RENDeGtRQitVM3N4aXBMODZXNDZwb2F3VmlCTzgvNHgwR2hiN1o0T2Q5?= =?utf-8?B?cnlQZzUyb1JCc0wvZ2d2bnNzU2t1cGRQRnc3NkZXYjRSOU9hUkl3M0M0WE81?= =?utf-8?B?b0MyZ1BRdkZoRGdVdmVPR3h5WnY3S1JMU0k4dHQrd2FoUEQ5czZ2QUxPOERM?= =?utf-8?B?ZFd3dThXbnJRajlpc3RjNFdCTitjQ0MvWW9yTmpuZnRaeFMybHZGZndsSEVM?= =?utf-8?B?ZkkwQXFGU3NFZFQzcDIwYlpkaTY5c0lTYWp0cjJFd1lSU1dKVDVtL1AxQTRt?= =?utf-8?B?ekllbWpJaDBhQjV4TjhYY1QwL25wSTFGVytHcU05V0JsUnFtVE9mMTdxbmNq?= =?utf-8?B?aGRYUDQ5RkxCM3JmQlVWL1M3VDhmNU9DZENURWt6VjZvaXNseDdLeEJzbjNi?= =?utf-8?B?bEt3cktjbEhxOHRCQ0VseGZTTmp1SDkvWHgvZzRxR2tid1p6THRvSnpCc3di?= =?utf-8?B?WnlRUUF4QlU0NFdZWlpqR0theGdpeVVJWXZ6YVU4N21FRmF0VXJzeEJPSDVQ?= =?utf-8?B?S3RzdkZNMmR4ZW9qZE9GczBiRUJTUFp1eG05OGQyMmlYWllqS0JNYVlUUzhB?= =?utf-8?Q?DV0CqUkajrIECRN22CLjKchDEv8lNgid?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3089; 6:e29ZS369BtTHi/QbDt/Q87SwMTNtGAYOyxJZ3EUlO6i6ehe7qW326/Afj7LVtJoFOkdtsy18atGyo7erBGU2xq2/kN9g91Qayo+/HTRpqhpWd9aajJW7U9AjMoFl4I7NHe91KKioEUn7R5qFe6AY6Y9QWrJhbrxWaxh+5Au7HBB9zEr3v0KST9hnP6PLTfuinBQZyzCS/bzEBbf7RZDf+2lpWriPCCDDRzY2ir+HhbfAzh+tfuKGH09SCsmG7AUIfmu8pu+hR+RfuLTUjZRoPZgtQdkY4UovvvIXqPNaczG8Qc3PrIh9pccpivNlUR0eilax86WdIab89sZ9az2nTw==; 5:naVnYRokAbINWwmQM3y74xKc4Woh7nfnk690tsdenrXHP79xCG96SFm+ggMnuF0bCfwi1HbGa4iog+zEv8Ed/rwSYYqO+tnPMaF7JCNY3rBRygQkQdtGm4eHQwN0RgUmBCxhbP78QNzRgZqomHUIiQ==; 24:cEJtgtJspxH0/1hUpOl4obQrtXmShkbGRgvcfKSCIxP+alQOF6t3bY7zyUIsjhbhazvp9WYHJHwqrXToMjL/G2hVTFPApbv5wh0xbTNLGGA=; 7:T5ecowqYhZOShvcW3DlnS9BL4g2u0WvtJk4Qk+t+I2CgLXMgWc7XYsWQPmVgJaSS7uGx8PCp9xqN8PNRJZMnNDo++nj7n+KUgcGnS8jNeecMTXLt9Ha+qYMMENueH3fkza3C4Y9UIZAIkpni372tP8v5AnVrECPF4FscvYlFxMl2qhwNcslhk7/fWoCVJh2lPROj/ekekiUUlXLtGd13+Y69cRLEcGvEqI712fwTOqE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2017 10:25:02.3620 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3089 Subject: Re: [dpdk-dev] [PATCH v8 2/9] eal/pci: get iommu class X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 20 Sep 2017 10:25:06 -0000 Hi Anatoly, On Wednesday 20 September 2017 02:39 PM, Burakov, Anatoly wrote: > Hi Santosh, > > On 19-Sep-17 6:29 PM, santosh wrote: >> Hi Anatoly, >> >> >> On Tuesday 19 September 2017 10:07 PM, Burakov, Anatoly wrote: >>> On 18-Sep-17 11:42 AM, Santosh Shukla wrote: >>>> Introducing rte_pci_get_iommu_class API which helps to get iommu class >>>> of PCI device on the bus and returns preferred iova mapping mode for >>>> PCI bus. >>>> >>>> Patch also add rte_pci_get_iommu_class definition for bsdapp, >>>> in bsdapp case - api returns default iova mode. >>>> >>>> Signed-off-by: Santosh Shukla <santosh.shukla at caviumnetworks.com> >>>> Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com> >>>> Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com> >>>> --- >>> >>> Hi Santosh, >>> >>> You have probably missed my comment on previous version of this patch, but for commit history reasons i really think you should add a linuxapp stub in this commit as well as a FreeBSD stub, even though you are adding a linuxapp function in the next commit. Any linuxapp application using that function will fail to compile with this commit, despite this API being already present and declared as public. >>> >> First, apologies for not following up on your note: >> >> I prefer to keep less context in each patch and >> for [03/9], its already has _IOVA_AS_VA flag + whole autodetection >> algo inside (squashed per Aron suggestion). >> Now if I squash [2/9] into [3/9], then would be too much info >> for future reader to digest for (imo). Its a kind of trade-off. >> >> On any linuxapp appl breaking with this commit: >> This series exposes eal api for application to use and identify iova mode. >> >> If you still feel not convinced with my explanation then I'll spin v9 and squash >> [02/09], [03/09] in v9. > > No, i don't mean squashing these two patches into one. I mean, provide a stub like for FreeBSD, and then edit it to be a proper implementation in the next commit. > > I.e. in this commit, add a stub that just returns 0, like for FreeBSD. Next commit, instead of starting from scratch, start from this stub. > +1, Sending v9. Thanks. > Thanks, > Anatoly > >> >> Thanks. >> >> >> > >