From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F3CEA00C5; Sun, 5 Jul 2020 22:23:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3E391D8F8; Sun, 5 Jul 2020 22:23:56 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 7EE4F1D8F4 for <dev@dpdk.org>; Sun, 5 Jul 2020 22:23:55 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 07846580421; Sun, 5 Jul 2020 16:23:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 05 Jul 2020 16:23:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= KiLAyQQyqemaCTTQ02zUaRjWcLN2A2xs7G/BecEFXPs=; b=xzyOOABBJa0pzjhA M4Y+WhT+ieQkzH+guccyNSU005HLmVVGkoAFGg5EDFFfn7phECMnE8uiCmUpzMtt 55WoCujTq2V63k35ZFBEBWMehb7SvxE9EXxgsYedaBxd6e+LBFibkWvz/1aiR3md ropjDVa1kRwvr1sCSlIEelvkPwrVqW1dii1u408Uyuiit4qWp3iFYWbmTHzZ+QDX 5Wkb30aFkm5rDTZYWN7IaUeDfIi643Sl0QUe8uVHBLJWlP0U5OLzgZD1OGt5Raz4 e7aksp2LzTRvUx/VL/nWL4vgSr41aowGTNsAe6xg8yhlb1J4kd7ny/mKc3LHBr83 cQGDww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=KiLAyQQyqemaCTTQ02zUaRjWcLN2A2xs7G/BecEFX Ps=; b=Fl8MK17skk1DCvWGbUL3ZMfd/RIU8nzJPfgMwi6tj3qY3bbym1/srBA8y 5FDGxQ6gxZWByeyXZWKKNaBk2BCReQLi8VcuLEn6jKmTTrEtwO2OwwtG9MN+PV3R hX3DLuqoZZOHMY+CEi4L+I8SQyaW2ADCilIPX29Fyo9hcxANxQpwv4fCqaYsRVBu mc1C8KiM5CbMjYOG0NdxNxonjRIRnYs2xEfKt10fZnN6iX4jpSTr2gyO1Y6zKVpW O/iSVr9fgYfiKykLGhwG+UBejDwhxi9t0yBodmtOhTA6fUC8ULdNsMFZaDyXruze shLKRMzQV1gEgnT1rBzeSZ2388P3A== X-ME-Sender: <xms:2jYCX2ogtE6oaWSrkKELdljgeIE7zCl_sVozzlyOCc01c_6QBvCuaA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddugdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:2jYCX0olf23BcWyu51h9Dxz4q1TZ4eVfdzrVITppf-Mq8KWm_WPugg> <xmx:2jYCX7O0O16uE6sTBmhQY8afsQac2dwiYkB15PuyAYDklAzW1oO3VA> <xmx:2jYCX14urNfSn7NwdwtPgdq_CfosM8YHJNiKBgplltgFPbQXh8OCrw> <xmx:2jYCXyzczHhqP5EsIpRHBe3iRboUd1oR3Gl0qOv9xBCMtE1TuMMM4A> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E0CD7306AAA6; Sun, 5 Jul 2020 16:23:52 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Fady Bader <fady@mellanox.com> Cc: dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com, arybchenko@solarflare.com, mdr@ashroe.eu, nhorman@tuxdriver.com Date: Sun, 05 Jul 2020 22:23:51 +0200 Message-ID: <6814192.mXDoOMZkCk@thomas> In-Reply-To: <20200705134746.26240-2-fady@mellanox.com> References: <20200705114629.2152-1-fady@mellanox.com> <20200705134746.26240-1-fady@mellanox.com> <20200705134746.26240-2-fady@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 05/07/2020 15:47, Fady Bader: > Function versioning implementation is not supported by Windows. > Function versioning was disabled on Windows. was -> is > Signed-off-by: Fady Bader <fady@mellanox.com> > --- > lib/librte_eal/include/rte_function_versioning.h | 2 +- > lib/meson.build | 5 +++++ > 2 files changed, 6 insertions(+), 1 deletion(-) As suggested by Ray, we should add a note in the documentation about the ABI compatibility. Because we have no function versioning, we cannot ensure ABI compatibility on Windows. I recommend adding this text in doc/guides/windows_gsg/intro.rst under "Limitations": " The :doc:`../contributing/abi_policy` cannot be respected for Windows. Minor ABI versions may be incompatible because function versioning is not supported on Windows. "