From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Marcin Kerlin <marcinx.kerlin@intel.com>, david.marchand@6wind.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 1/1] eal: fix resource leak of mapped memory
Date: Thu, 16 Jun 2016 13:57:43 +0100 [thread overview]
Message-ID: <6821d6bd-7126-388a-1160-4ae4a20dc80e@intel.com> (raw)
In-Reply-To: <1465993510-13448-1-git-send-email-marcinx.kerlin@intel.com>
On 15/06/2016 13:25, Marcin Kerlin wrote:
> Patch fixes resource leak in rte_eal_hugepage_attach() where mapped files
> were not freed back to the OS in case of failure. Patch uses the behavior
> of Linux munmap: "It is not an error if the indicated range does not
> contain any mapped pages".
>
> v4:
> 1)removed keyword const from pointer and dependent on that casting (void *)
> v3:
> 1)removed redundant casting
> 2)removed update error message
> v2:
> 1)unmapping also previous addresses
The patch version history should be after the triple dash below so it
won't show up
on git log.
> Coverity issue: 13295, 13296, 13303
> Fixes: af75078fece3 ("first public release")
>
> Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>
> ---
Insert here patch version history.
> lib/librte_eal/linuxapp/eal/eal_memory.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
> index 79d1d2d..c935765 100644
Thomas, are you ok to update the commit message? Otherwise, please
Mercin do v5 with changes and keep my ack.
Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
next prev parent reply other threads:[~2016-06-16 12:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 16:27 [dpdk-dev] [PATCH 1/1] lib/librte_eal: fix resource leak Marcin Kerlin
2016-04-20 9:15 ` David Marchand
2016-04-21 11:19 ` Sergio Gonzalez Monroy
2016-04-21 11:49 ` Kerlin, MarcinX
2016-04-22 10:42 ` Panu Matilainen
2016-06-14 15:33 ` [dpdk-dev] [PATCH v2 1/1] eal: fix resource leak of mapped memory Marcin Kerlin
2016-06-15 8:49 ` Sergio Gonzalez Monroy
2016-06-15 9:35 ` Kerlin, MarcinX
2016-06-15 10:05 ` Panu Matilainen
2016-06-15 11:13 ` Kerlin, MarcinX
2016-06-15 10:45 ` [dpdk-dev] [PATCH v3 " Marcin Kerlin
2016-06-15 12:25 ` [dpdk-dev] [PATCH v4 " Marcin Kerlin
2016-06-16 12:57 ` Sergio Gonzalez Monroy [this message]
2016-06-16 15:14 ` [dpdk-dev] [PATCH v5 " Marcin Kerlin
2016-06-20 9:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6821d6bd-7126-388a-1160-4ae4a20dc80e@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=marcinx.kerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).