From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 95C87C4DC for ; Thu, 16 Jun 2016 14:57:46 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 16 Jun 2016 05:57:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,480,1459839600"; d="scan'208";a="123015880" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.220.73]) ([10.237.220.73]) by fmsmga004.fm.intel.com with ESMTP; 16 Jun 2016 05:57:45 -0700 To: Marcin Kerlin , david.marchand@6wind.com References: <1465987510-11491-1-git-send-email-marcinx.kerlin@intel.com> <1465993510-13448-1-git-send-email-marcinx.kerlin@intel.com> Cc: dev@dpdk.org From: Sergio Gonzalez Monroy Message-ID: <6821d6bd-7126-388a-1160-4ae4a20dc80e@intel.com> Date: Thu, 16 Jun 2016 13:57:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1465993510-13448-1-git-send-email-marcinx.kerlin@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/1] eal: fix resource leak of mapped memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2016 12:57:47 -0000 On 15/06/2016 13:25, Marcin Kerlin wrote: > Patch fixes resource leak in rte_eal_hugepage_attach() where mapped files > were not freed back to the OS in case of failure. Patch uses the behavior > of Linux munmap: "It is not an error if the indicated range does not > contain any mapped pages". > > v4: > 1)removed keyword const from pointer and dependent on that casting (void *) > v3: > 1)removed redundant casting > 2)removed update error message > v2: > 1)unmapping also previous addresses The patch version history should be after the triple dash below so it won't show up on git log. > Coverity issue: 13295, 13296, 13303 > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Marcin Kerlin > --- Insert here patch version history. > lib/librte_eal/linuxapp/eal/eal_memory.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c > index 79d1d2d..c935765 100644 Thomas, are you ok to update the commit message? Otherwise, please Mercin do v5 with changes and keep my ack. Acked-by: Sergio Gonzalez Monroy