From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A83974CE4; Mon, 29 Oct 2018 00:55:13 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4783421EA7; Sun, 28 Oct 2018 19:55:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 28 Oct 2018 19:55:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=G2f0P6lstrVMSPEq874oaWmoHqutnjLeQwnfv/OfcAM=; b=PneKnGkvx9cH 6U5XzanUa6I7JRfhnaYa9JP2yqrV0xThpSmC8S+3lmL6rvmfCYWAmO5sfvTUH451 L/WGbbm87f9usn8lI/4GAIJIy2ZNAaJA1r766Bmp//v4xBBfLCW+a2W2DlUY11Gd mNAJNrPX5VnhQec7WqmHY+ulskdoN7A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=G2f0P6lstrVMSPEq874oaWmoHqutnjLeQwnfv/Ofc AM=; b=Shu0MFNFlwB5ZVm60m1K48/oSCvgUlgOB+84nh0W39w+hseqq1iDRa1l8 kr/QdN9ack5vPhE3pFtWEOZpWVKVzBAI8+QhJID0aZPjL2f+dCbaALQl7UMuUbhf cPD0X+BNA1B4r8/yUbHHoni6Sd/g0C/pgXgLWBUtFVAFucdTHAJ69M8Wz/B2I7g6 Hc0GDO8XxDnz7745HfUvSEoY1QCoIamKBhpbsMq9N5x2k6CWzudXHFn5LbGr6mPq Gu7e8Ztxu6zQlUx54uGwJij6APRhKNsi2vIgbNVsbmxzKq+3jojm9BgHhmBhf0qa fbGddBIEOjaalPL9qn64BpKZCCyCA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7AE51E4430; Sun, 28 Oct 2018 19:55:11 -0400 (EDT) From: Thomas Monjalon To: Luca Boccassi Cc: dev@dpdk.org, Tiwei Bie , maxime.coquelin@redhat.com, zhihong.wang@intel.com, bruce.richardson@intel.com, brian.russell@intl.att.com, stable@dpdk.org Date: Mon, 29 Oct 2018 00:55:17 +0100 Message-ID: <6822792.WN0bvDObni@xps> In-Reply-To: <20181011130100.GA628@debian> References: <20180827165240.28322-1-bluca@debian.org> <1539255192.8721.31.camel@debian.org> <20181011130100.GA628@debian> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 2/2] net/virtio: fix PCI config err handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2018 23:55:14 -0000 11/10/2018 15:01, Tiwei Bie: > On Thu, Oct 11, 2018 at 11:53:12AM +0100, Luca Boccassi wrote: > > On Thu, 2018-10-11 at 12:27 +0200, Thomas Monjalon wrote: > > > 28/08/2018 12:12, Luca Boccassi: > > > > From: Brian Russell > > > > > > > > In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config > > > > returns > > > > the number of bytes read from PCI config or < 0 on error. > > > > If less than the expected number of bytes are read then log the > > > > failure and return rather than carrying on with garbage. > > > > > > > > Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0") > > > > > > > > Signed-off-by: Brian Russell > > > > Signed-off-by: Luca Boccassi > > > > --- > > > > v2: handle additional rte_pci_read_config incomplete reads > > > > v3: do not handle rte_pci_read_config of virtio cap, added in v2, > > > > as it's less clear what the right thing to do there is > > > > v4: do a more robust check - first check what the vendor is, and > > > > skip the cap entirely if it's not what we are looking for. > > > > v5: fetch only 2 flags bytes if the vndr is PCI_CAP_ID_MSIX > > > > v6: fix 32bit build by changing the printf format specifier, fix > > > > patch title > > > > > > Tiwei did a comment on v5 and provided his Reviewed-by. > > > Is it OK to apply v6 with its tag? > > > All is fixed? > > > > Hi, > > > > The title has been fixed (virtio -> net/virtio) and I just tried a > > 32bit build and it works fine after the fix from v6. > > Thanks Luca! > > Reviewed-by: Tiwei Bie Cc: stable@dpdk.org Series applied, thanks