From: "Ramia, Kannan Babu" <kannan.babu.ramia@intel.com>
To: Nikhil Jagtap <nikhil.jagtap@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] meter: excess token bucket update in srtcm
Date: Tue, 6 Sep 2016 05:10:26 +0000 [thread overview]
Message-ID: <682698A055A0F44AA47192B20141149762528A49@BGSMSX102.gar.corp.intel.com> (raw)
In-Reply-To: <CANKBMf1bYNXr7yNPhQAuhDEA=99u3+1fnrfLXbNkp++B-47pmw@mail.gmail.com>
Hi Nikhil
You could submit a patch, something like that below logic
If( ((n_periods * m->cir_bytes_per_period) > (m->cbs-m->tc))
te = m->te + ((n_periods * m->cir_bytes_per_period) - (m->cbs-m->tc));
and this should be done before m->tc update.
Regards
Kannan Babu
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nikhil Jagtap
Sent: Tuesday, September 6, 2016 9:43 AM
To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] meter: excess token bucket update in srtcm
Hi,
Can someone please comment on this?
Nikhil
On 31 August 2016 at 15:32, Nikhil Jagtap <nikhil.jagtap@gmail.com> wrote:
> Hi,
>
> As per srTCM RFC 2697, we should be updating the E bucket only after
> the C bucket overflows.
> "Thereafter, the token counts Tc and Te are updated CIR times per
> second as follows:
> o If Tc is less than CBS, Tc is incremented by one, else
> o if Te is less then EBS, Te is incremented by one, else
> o neither Tc nor Te is incremented."
>
> However in the current DPDK implementation of srTCM, we are updating
> both the buckets simultaneously at the same rate (CIR). This will
> result in a token accumulation rate of (2*CIR). This seems like a bug
> to me. Can you confirm this?
>
> Nikhil
>
>
next prev parent reply other threads:[~2016-09-06 5:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 10:02 Nikhil Jagtap
2016-09-06 4:13 ` Nikhil Jagtap
2016-09-06 5:10 ` Ramia, Kannan Babu [this message]
2016-09-06 6:29 ` Nikhil Jagtap
2016-09-06 9:56 ` Dumitrescu, Cristian
2016-09-07 6:22 ` Nikhil Jagtap
2016-09-09 21:00 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682698A055A0F44AA47192B20141149762528A49@BGSMSX102.gar.corp.intel.com \
--to=kannan.babu.ramia@intel.com \
--cc=dev@dpdk.org \
--cc=nikhil.jagtap@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).