From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD4FD425D7; Mon, 18 Sep 2023 16:51:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A17640685; Mon, 18 Sep 2023 16:51:46 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 993F44025C for ; Mon, 18 Sep 2023 16:51:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695048705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WOvXzINU6wbOAmP9TzHfx6Q2eEgAMjfC8I6RELyrP6I=; b=CtCeqt52iRqRJEaJM4s4dgjkMBs4mCGMxscH30yGMZ7kq3Gn25mkiZaqZO90IUP7P0N6Z7 Ch/2v0uahc52RKIAQ7Iu6t08KZef1bm9RZMwj69eYIA8oMDcXgzCzG0RvsERxCm5YRuzzO 6qD0IDPzGR0r1qsMCQe/nsRros/Pr14= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-xPqVQghwOpO0tochoC3h9g-1; Mon, 18 Sep 2023 10:51:44 -0400 X-MC-Unique: xPqVQghwOpO0tochoC3h9g-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-404daa4f3c1so17359265e9.1 for ; Mon, 18 Sep 2023 07:51:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695048696; x=1695653496; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WOvXzINU6wbOAmP9TzHfx6Q2eEgAMjfC8I6RELyrP6I=; b=gHugqOwgHh+iotpKorKHUGONjpF9FC9DSq30NM0y6xVrcReZvMTISbDba7v7crEcGx 42sYWrtwNrTVdEkw8vOaeZBODOFb3PeczTindcW4KqSs8M9Y6QVKGXtKP5IU4clNassg YMW/gxda/D5BNM5ATwSd0Z1J9RZCiF1BKayl+q/lYiiphND2SO0mMidnhIqhq2D3od8V pT1671fhHDXRMw7+r55nOYiiKhKTsaT2hOy1KW28GzDQ6opOuASf8skattkaXVStElwY bz9qhufz6H8KZmEwwq5+vy84u2LVgbefL7tIi007pPTyqjZ4b5x34LZc0xXoLzO9gnj3 BRwQ== X-Gm-Message-State: AOJu0YxwGegVkvjpDoIAKXlhwbc3gC+eAWFsF5T9Y9UeSqRIS/EqPqiG 4i3u4NrzP4Qr7zcAAq38y9LQ5O1AfMJxjYW4aL1BTRxBPj1PUMpOIRLZLvN7O3+Qc8E8grPTWia LSN5qBH7KGUQ= X-Received: by 2002:a05:600c:21d8:b0:404:74e3:27a4 with SMTP id x24-20020a05600c21d800b0040474e327a4mr7343810wmj.40.1695048696560; Mon, 18 Sep 2023 07:51:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1ZwhvR/Xc03Hn61Ctu9fH0kQ4qxB8XnWvdcoeAG8BL8z0Gu8Hxb8+jqgGpWXOn8H5CrJNUQ== X-Received: by 2002:a05:600c:21d8:b0:404:74e3:27a4 with SMTP id x24-20020a05600c21d800b0040474e327a4mr7343797wmj.40.1695048696270; Mon, 18 Sep 2023 07:51:36 -0700 (PDT) Received: from [192.168.0.36] ([78.17.182.90]) by smtp.gmail.com with ESMTPSA id s24-20020a7bc398000000b003feee8d8011sm15675639wmj.41.2023.09.18.07.51.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 07:51:35 -0700 (PDT) Message-ID: <683bf409-df05-89ee-edaa-020a3ecccbca@redhat.com> Date: Mon, 18 Sep 2023 15:51:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 0/2] check illegal packets To: David Marchand , Kevin Liu , qi.z.zhang@intel.com Cc: dev@dpdk.org, qiming.yang@intel.com, stevex.yang@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com, Mike Pattrick References: <20220922070426.788643-1-kevinx.liu@intel.com> <20220927071522.3656059-1-kevinx.liu@intel.com> From: Kevin Traynor In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 18/09/2023 15:42, David Marchand wrote: > On Tue, Sep 27, 2022 at 9:24 AM Kevin Liu wrote: >> >> Check whether the data packet is illegal of ice and iavf driver. >> >> v2: >> Change the scheme, check the data_len and update commit log. >> >> Kevin Liu (2): >> net/iavf: check illegal packets >> net/ice: check illegal packets >> >> drivers/net/iavf/iavf_rxtx.c | 9 +++++++++ >> drivers/net/iavf/iavf_rxtx.h | 2 ++ >> drivers/net/ice/ice_rxtx.c | 11 +++++++++++ >> drivers/net/ice/ice_rxtx.h | 2 ++ >> 4 files changed, 24 insertions(+) > > This series looks wrong to me. > > - What happens if the application requests TSO to the nic? > - Checking data_len of a mbuf means only checking the size of the > first segment, so if any limitation applies to the packet size, it > should by checking pkt_len. > > I will probably send reverts for the two patches. > > there is a fix also that needs to be checked: 688cb2f2c61e ("net/ice: fix scalar Tx path segment")