DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: christian.ehrhardt@canonical.com,
	Luca Boccassi <bluca@debian.org>,
	Xueming Li <xuemingl@nvidia.com>,
	David Marchand <david.marchand@redhat.com>,
	Kevin Traynor <ktraynor@redhat.com>
Cc: dev <dev@dpdk.org>, Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v2 1/2] devtools: don't include headline "fix" in backports
Date: Sat, 26 Nov 2022 22:35:22 +0100	[thread overview]
Message-ID: <6843476.18pcnM708K@thomas> (raw)
In-Reply-To: <5824d156-0bd8-3b61-38aa-d34c551b342c@redhat.com>

03/12/2021 15:04, Kevin Traynor:
> On 03/12/2021 07:54, christian.ehrhardt@canonical.com wrote:
> > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > 
> > It was important in the past to select anything with "fix" in the
> > headline, but recently more often created false positives and work
> > to sort tihngs out than identifying many helpful patches.
> > 
> > The community and processes aroudn DPDK matured enough that developers
> > (rightfully) expect to rely on "Fixes:" and "stable@" marking for
> > backprots.
> 
> nit: several typos here and i think it should say "or" stable@
> 
> > 
> > Therefore do no more include patches that just include the word fix
> > in the backport candidate list.
> > 
> > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > ---
> >   devtools/git-log-fixes.sh | 5 ++---
> >   1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> > index 210c8dcf25..27ec9088d4 100755
> > --- a/devtools/git-log-fixes.sh
> > +++ b/devtools/git-log-fixes.sh
> > @@ -13,7 +13,7 @@ print_help ()
> >   	cat <<- END_OF_HELP
> >   
> >   	Find fixes to backport on previous versions.
> > -	It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts".
> > +	It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org.
> 
> "..or for recipient stable@dpdk.org."
> 
> Good idea, thanks. With minor fixes,
> 
> Acked-by: Kevin Traynor <ktraynor@redhat.com>

After one year, nits above have not been fixed, so I'm doing it myself.

While at it, remove "Reverts" from help because not parsed in reality.

Series applied with above changes.



  reply	other threads:[~2022-11-26 21:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03  7:54 christian.ehrhardt
2021-12-03  7:54 ` [PATCH v2 2/2] devtools: report commit id on partial fixes christian.ehrhardt
2021-12-03 12:24   ` Luca Boccassi
2021-12-03 14:05   ` Kevin Traynor
2021-12-05 11:35   ` Xueming(Steven) Li
2021-12-03 12:24 ` [PATCH v2 1/2] devtools: don't include headline "fix" in backports Luca Boccassi
2021-12-03 14:04 ` Kevin Traynor
2022-11-26 21:35   ` Thomas Monjalon [this message]
2021-12-05 11:38 ` Xueming(Steven) Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6843476.18pcnM708K@thomas \
    --to=thomas@monjalon.net \
    --cc=bluca@debian.org \
    --cc=christian.ehrhardt@canonical.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).