From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8EA9A0557; Sat, 26 Nov 2022 22:35:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 821FE400EF; Sat, 26 Nov 2022 22:35:27 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id D6FED40041 for ; Sat, 26 Nov 2022 22:35:26 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6B2EB5C009E; Sat, 26 Nov 2022 16:35:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 26 Nov 2022 16:35:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1669498525; x= 1669584925; bh=1vIQ58YsK/xtF/E3kmYgGsLMxlAcMyi16nMICbbsv98=; b=L XKhysdE7V2gF9DHfr68QspyA5ExbB09umr+2IMmKVq3xSkfoVFqDnr/NhoSAlmGr 40noYSNRfNNStA3YsUwTiw8M49NN9k+yqtiG3/k6sWDN6DGlz2edDZ9KeEgFAsQZ DUKtgqFJgjkAvv+SgaGaihM+ePiIPLOZ5OOTOD+WpkUxDkmzPiBSNX4r4cz862Y4 nJA2WJnX6Ne8b72O8vCRtXwgGZY2kp3ENFQHylSYjVxEZog9nUXtLhMHbYiH9a0b YYuznCsgtdE1YTxKQCV458vsGJIRHLw1ltUFwzwmCWWHdmL4R2r7CQ2S+BhX5Oau cULGjJKiG6RNebAsKVK5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669498525; x= 1669584925; bh=1vIQ58YsK/xtF/E3kmYgGsLMxlAcMyi16nMICbbsv98=; b=U Y1AG3cutCGAzGK+qYQS5+T12QRzgKfS3EuwshD4RfU/SDGEqS+Mn50BpRoyEaIvD w/PELwZV320R7iP1yQbV2R8KkFj8agNQ/As9LUjecK+4y9v2M+DnqWmASgS4ixR9 fYdBNttxcR9NVgveADJDTmlpmdRq/oku+pyUiJo6mMhgP4H9Ej7o58FmTc8aPteb 7T7tg/nVnt8o6zqZO+0CPi+rVDkTztGqRvfDl7f7BVWkvbX+4X3Stcqo/x6q9gvZ VGsvT7tIMMIxMPDCk63gsDTLYs+rayvcuQveFs7YCcit5VZQ+c7a/sXLHg+jNi45 WxBOHt/rEvf1tgWdDrX2w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieejgdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Nov 2022 16:35:24 -0500 (EST) From: Thomas Monjalon To: christian.ehrhardt@canonical.com, Luca Boccassi , Xueming Li , David Marchand , Kevin Traynor Cc: dev , Maxime Coquelin Subject: Re: [PATCH v2 1/2] devtools: don't include headline "fix" in backports Date: Sat, 26 Nov 2022 22:35:22 +0100 Message-ID: <6843476.18pcnM708K@thomas> In-Reply-To: <5824d156-0bd8-3b61-38aa-d34c551b342c@redhat.com> References: <20211203075415.4083502-1-christian.ehrhardt@canonical.com> <5824d156-0bd8-3b61-38aa-d34c551b342c@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 03/12/2021 15:04, Kevin Traynor: > On 03/12/2021 07:54, christian.ehrhardt@canonical.com wrote: > > From: Christian Ehrhardt > > > > It was important in the past to select anything with "fix" in the > > headline, but recently more often created false positives and work > > to sort tihngs out than identifying many helpful patches. > > > > The community and processes aroudn DPDK matured enough that developers > > (rightfully) expect to rely on "Fixes:" and "stable@" marking for > > backprots. > > nit: several typos here and i think it should say "or" stable@ > > > > > Therefore do no more include patches that just include the word fix > > in the backport candidate list. > > > > Signed-off-by: Christian Ehrhardt > > --- > > devtools/git-log-fixes.sh | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh > > index 210c8dcf25..27ec9088d4 100755 > > --- a/devtools/git-log-fixes.sh > > +++ b/devtools/git-log-fixes.sh > > @@ -13,7 +13,7 @@ print_help () > > cat <<- END_OF_HELP > > > > Find fixes to backport on previous versions. > > - It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts". > > + It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org. > > "..or for recipient stable@dpdk.org." > > Good idea, thanks. With minor fixes, > > Acked-by: Kevin Traynor After one year, nits above have not been fixed, so I'm doing it myself. While at it, remove "Reverts" from help because not parsed in reality. Series applied with above changes.