From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7A100A00C4;
	Mon, 25 Jul 2022 13:04:04 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6B26841144;
	Mon, 25 Jul 2022 13:04:04 +0200 (CEST)
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
 by mails.dpdk.org (Postfix) with ESMTP id 019DA4067C
 for <dev@dpdk.org>; Mon, 25 Jul 2022 13:04:01 +0200 (CEST)
Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.53])
 by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LrxtF2fBFz1M8Gg;
 Mon, 25 Jul 2022 19:01:09 +0800 (CST)
Received: from [10.67.103.235] (10.67.103.235) by
 kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.24; Mon, 25 Jul 2022 19:03:59 +0800
Subject: Re: [PATCH 0/6] app/procinfo: add some extended features
To: David Marchand <david.marchand@redhat.com>
References: <20220722091236.15469-1-liudongdong3@huawei.com>
 <CAJFAV8w0nV1=w1Lk2-j3Qu3FJfbkyzYmGrXTrKFwLRuB2oZhdw@mail.gmail.com>
CC: dev <dev@dpdk.org>, "Pattan, Reshma" <reshma.pattan@intel.com>, Thomas
 Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@xilinx.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
From: Dongdong Liu <liudongdong3@huawei.com>
Message-ID: <68442c12-55ce-9ef2-74b9-fb7fdf2fedaa@huawei.com>
Date: Mon, 25 Jul 2022 19:03:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <CAJFAV8w0nV1=w1Lk2-j3Qu3FJfbkyzYmGrXTrKFwLRuB2oZhdw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.103.235]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
 kwepemi500017.china.huawei.com (7.221.188.110)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi David

Many thanks for your review.
On 2022/7/22 18:03, David Marchand wrote:
> On Fri, Jul 22, 2022 at 11:13 AM Dongdong Liu <liudongdong3@huawei.com> wrote:
>>
>> [PATCH 1/6 2/6 3/6] support ethdev info about firmware version, RSS reta info,
>> and module info, from the below link [1] that have been sent out in the
>> earlier,  wait for review.
>> [PATCH 4/6] add dump of Rx/tx burst mode.
>> [PATCH 5/6] fix some wrong doxygen syntax for procinfo suggested by Thomas.
>> [PATCH 6/6] update the procinfo doc guide.
>>
>> [1] https://lore.kernel.org/dpdk-dev/20220527014259.38559-1-humin29@huawei.com/
>
> Some applications may not want to use multiprocess.
> Do you know if those added informations are available through telemetry?

After a quick look at telemetry doc guide and do some telemetry test.
--> /info
It displays dpdk version  but not include ethdev firmware version.
The ethdev firmware version maybe better to be added for /ethdev/info
cmd.

--> /ethdev/module_eeprom,0
It displays ports module eeprom information.

RSS reta info, Rx/Tx burst mode have not been supported by telemetry.
It is a good idea to add these features through telemetry.

This patchset add some extended features for procinfo, we can also
apply them, later will add these features through telemetry.

Current some features have been supported by procinfo in dpdk mainline
code, but not supported by telemetry, maybe we can also implement them 
through telemetry.

Thanks,
Dongdong

>
>