From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEB3EA0C41; Wed, 23 Jun 2021 10:05:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F16A4003F; Wed, 23 Jun 2021 10:05:44 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id D44FD4003E for ; Wed, 23 Jun 2021 10:05:42 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 6E6175C018C; Wed, 23 Jun 2021 04:05:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 23 Jun 2021 04:05:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= zN3wa0FMpk0e5pZf6jO4AIgIQG/Udla8PfCLAzcl8Mg=; b=Zn232Bjy2glDOBgU 5ZqO6H0hHeC6obDeYd04s6igqt+o8SQh+vuDgCq//EGLXn0JVD3LCFdBzZoaVOsN ZEbURxzNuSLbb73aPjOriADdNQhyXWQ9Mqh4iAWq6tym19Fbm2a4UeCFiECsfBOO CbuwvGvHwzG0IyJH7aT5a4wbgOEPCdTfuT4SPzJxHS4QhgIa8339afyfuRKCEK6v lop2UagWU6nagiqO52EnDanky2P1Y3S4kVqFhP2dfsFYYvYJlbqNxgzRTluPdheF sH0svX+wYPYQ6UNfha6D3MI+KrxcAoveXtDx1NWRJ+VSE7PiNCgOnTZ7eLNdw//G THZP3w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=zN3wa0FMpk0e5pZf6jO4AIgIQG/Udla8PfCLAzcl8 Mg=; b=BcqMvkIigHFKWxyyTrL1fVkmsE006j4A1yz8ChB924JsUQqAN5oeTkYiA Z2YtrEyRlb8tLFzE0ksMxR+6H5F/eq0Q0cTU3U3OzhHHZLTismi2YokWYcEHUgwq wKGYGvFv6KPBEDWis9uHOmyfAJwDvjWqI8WDWL/ftiut82LC66YC2YEJ06thwREd P3PCG6eFthEd78L9Q8OcgP2qlzIZ70DjVkZQPr8AB9Cfzq4vGThOSafzhsewqjXS GfZr2Q0iNogG6vDKrL6rTfx+pPuXwhZ30a4WFWOOaXasB2TOpXjSIYUpyPZdGmVm RveLWWG81wSjhMdVzYT2EsCEtPuQQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeegfedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Jun 2021 04:05:39 -0400 (EDT) From: Thomas Monjalon To: Chengwen Feng Cc: ferruh.yigit@intel.com, ruifeng.wang@arm.com, dev@dpdk.org, bruce.richardson@intel.com, vladimir.medvedkin@intel.com, viktorin@rehivetech.com, jerinj@marvell.com Date: Wed, 23 Jun 2021 10:05:37 +0200 Message-ID: <6856400.AbmscCdnZU@thomas> In-Reply-To: <1621562002-10961-1-git-send-email-fengchengwen@huawei.com> References: <1621495007-28387-1-git-send-email-fengchengwen@huawei.com> <1621562002-10961-1-git-send-email-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] build: fix SVE compile error with gcc8.3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/05/2021 03:53, Chengwen Feng: > If the target machine has SVE feature (e.g. "-march=armv8.2-a+sve'), > and the compiler are gcc8.3, it will compile error: > In file included from ../dpdk-next-net/lib/eal/common/ > eal_common_options.c:38: > ../dpdk-next-net/lib/eal/arm/include/rte_vect.h:13:10: fatal > error: arm_sve.h: No such file or directory > #include > ^~~~~~~~~~~ > compilation terminated. > > The root cause is that gcc8.3 supports SVE (the macro > __ARM_FEATURE_SVE was 1), but it doesn't support SVE ACLE [1]. > > The solution: > a) Detect compiler whether support SVE ACLE, if support then define > CC_SVE_ACLE_SUPPORT macro. > b) Use the CC_SVE_ACLE_SUPPORT macro to include SVE header file. > > [1] ACLE: Arm C Language Extensions, the SVE ACLE header file is > , user should include it when writing ACLE SVE code. > > Fixes: 67b68824a82d ("lpm/arm: support SVE") > > Signed-off-by: Chengwen Feng > --- > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > +if (cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != '' and > + cc.check_header('arm_sve.h')) > + dpdk_conf.set('CC_SVE_ACLE_SUPPORT', 1) Any defined flag should start with RTE_. I suggest RTE_HAS_SVE_ACLE. Please add a comment before defining this flag to explain what it is.