From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6FF4AA0C4C;
	Tue,  5 Oct 2021 19:36:27 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5A60141420;
	Tue,  5 Oct 2021 19:36:27 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 7093741417
 for <dev@dpdk.org>; Tue,  5 Oct 2021 19:36:26 +0200 (CEST)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 24F175C0229;
 Tue,  5 Oct 2021 13:36:26 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute6.internal (MEProxy); Tue, 05 Oct 2021 13:36:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 XvK42jxvZCayYllLlMZJWqFetXd5xMt6TeKu1efcL64=; b=rNkscCkdcj5rg+rl
 CqqOFWvxSRHz1c2M/mzBUq5Iv30EVbHMnHtm1AoKo0EQ60dWBjWiGYxcSvsbKWV+
 5912Kv1DV1GQDVRTZbuepjzW2/9I2SGaY0vRpHOeETLG0HsyErIRXifbp+NqH457
 xSB0FK31+yRXnv8rJowh5nSKkPrQOcNGin3vn66MjO1qJvjxlLCH5U4Nuega4EiJ
 lWX+I3zwuuI5c2GVgBZT7ni+o1qacjvNzwr94qG5+ZEkWZrwATgfX9E6S6SIzGWU
 5YbegZZip6MHCDULpzjNXXLMs8GvyozrLmG6a8ti/13rXrS9tHMJYMMvgwV7v0Uh
 MTlAbQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=XvK42jxvZCayYllLlMZJWqFetXd5xMt6TeKu1efcL
 64=; b=MY3/grBv+6zX3zwTgVeW0KcYdTMf/jg6vvxge6JiXzVUUr+ChQgksSxSB
 Rzd+4jW6PPj1XeOzhf9oHruzlzg/DvXfZ0+2L9MUoRj9AF0zpl+7X/1X+XbR+MWq
 IWhYcjTik8kMMlXF+i+RK7V0AzRf32uBpL+De4UU2R9NSS+4M5/ShHNJWD8UsgIN
 LIyzbEBIxLefqNg+FWvsJegrqzou1dCXm4xJ0PFBho6NSFaG80poThr+AB12/pCr
 /0q1w2P1oYu1sIwBDyL2PfzLK2zp0VfsxxmnMD3YA4CUqFm9R1H2hLmIExrZHFWc
 vgLabWyTq8XnLYRgSyKENVxlT1jdA==
X-ME-Sender: <xms:GY1cYWN5d_a8QUMBMehQ0-PwKjTHYJOcPYoNpy4DEixYtcPlxEpD7Q>
 <xme:GY1cYU-9J1FUGaa-ccjr5J3k7ge-wLfVxC2_U6Y9o0FrLXztg3nt6m_w6jobA1HKy
 ws4qaQ8hAwYVvs-nw>
X-ME-Received: <xmr:GY1cYdTsNEDr7O5Mg3XvtDV0dsVX9CFNeD58dm9ezSeeqilCAvBUzzSc1-M7jsY0RAj7-Op_P68wvo9sNw8Eu29ptHY53yq0-wJTVSb_cIs>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelgedgudduhecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
 rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
 ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
 ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
 hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:GY1cYWu6olP00A1o07Mr7HqoTibXA7uc3vc26Q2Owb_xVq2KTU06Mw>
 <xmx:GY1cYedFrbDfL2z-GgeZcWBxneAova9har2hs-0XBV8nIWBSQ6QN4w>
 <xmx:GY1cYa3pbio9eP63cx6T0NzEkETIQ-F5JfPUxRD-nSlJjABHIpPJhQ>
 <xmx:Go1cYd4D8FCx-BecnVVCRN73yzLDdE-q7UUzVtaEFhLNkojrlW4rHw>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 5 Oct 2021 13:36:24 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>,
 Dmitry Kozlyuk <dkozlyuk@oss.nvidia.com>
Cc: dev@dpdk.org, John Levon <john.levon@nutanix.com>,
 Viacheslav Ovsiienko <viacheslavo@oss.nvidia.com>, dkozlyuk@oss.nvidia.com
Date: Tue, 05 Oct 2021 19:36:21 +0200
Message-ID: <6865489.msH5K5uqSb@thomas>
In-Reply-To: <20210921081632.858873-2-dkozlyuk@nvidia.com>
References: <20210920125302.820273-1-dkozlyuk@nvidia.com>
 <20210921081632.858873-1-dkozlyuk@nvidia.com>
 <20210921081632.858873-2-dkozlyuk@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 1/3] eal/linux: make hugetlbfs analysis
 reusable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/09/2021 10:16, dkozlyuk@oss.nvidia.com:
> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> 
> get_hugepage_dir() searched for a hugetlbfs mount with a given page size
> using handcraft parsing of /proc/mounts and mixing traversal logic with
> selecting the needed entry. Separate code to enumerate hugetlbfs mounts
> to eal_hugepage_mount_walk() taking a callback that can inspect already
> parsed entries. Use mntent(3) API for parsing. This allows to reuse
> enumeration logic in subsequent patches.
> 
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

First version was sent in July.
Anatoly, please are you available to review?

> +++ b/lib/eal/linux/eal_hugepage_info.h
> @@ -0,0 +1,39 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright 2021 NVIDIA CORPORATION & AFFILIATES.

Please use this exact format:

Copyright (c) 2021 NVIDIA Corporation & Affiliates