From: Ananda Sathyanarayana <ananda@versa-networks.com>
To: dev@dpdk.org
Cc: ananda@versa-networks.com,
Vignesh Chinnakkannu <vigc@versa-networks.com>
Subject: [dpdk-dev] Manual link speed/duplex configuration not working with DPDK
Date: Fri, 21 Oct 2016 12:27:11 -0700 [thread overview]
Message-ID: <68694134d146c7848435452dad3446d9@mail.gmail.com> (raw)
Hi All,
While testing manual link speed/duplex configuration with DPDK 1.7.1, I
observed the same issues mentioned by the below post
http://dpdk.org/ml/archives/dev/2015-January/010834.html. I see the same
issue with 16.04 as well.
Looks like the above patch is not accepted by the DPDK community yet. Any
specific reason ?
>From the code, it looks like, hw->mac.autoneg, variable is used to switch
between calling either autoneg function or forcing speed/duplex function.
But this variable is not modified in eth_em_start/eth_igb_start routines
(it is always set to 1) while forcing the link.
s32 e1000_setup_copper_link_generic(struct e1000_hw *hw)
{
s32 ret_val;
bool link;
DEBUGFUNC("e1000_setup_copper_link_generic");
if (hw->mac.autoneg) { <<<<<<<<<<<< always set, is not modified
in eth_em_start/eth_igb_start
/* Setup autoneg and flow control advertisement and perform
* autonegotiation.
*/
ret_val = e1000_copper_link_autoneg(hw);
if (ret_val)
return ret_val;
} else {
/* PHY will be set to 10H, 10F, 100H or 100F
* depending on user settings.
*/
DEBUGOUT("Forcing Speed and Duplex\n");
ret_val = hw->phy.ops.force_speed_duplex(hw);
<<<<<<<<<<<< Not called at all
if (ret_val) {
DEBUGOUT("Error Forcing Speed and Duplex\n");
return ret_val;
}
}
}
Thanks,
Ananda
next reply other threads:[~2016-10-21 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 19:27 Ananda Sathyanarayana [this message]
2016-10-22 2:26 ` Anupam Kapoor
2016-10-24 0:54 ` Lu, Wenzhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68694134d146c7848435452dad3446d9@mail.gmail.com \
--to=ananda@versa-networks.com \
--cc=dev@dpdk.org \
--cc=vigc@versa-networks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).