From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D848A04FA; Wed, 5 Feb 2020 17:53:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8A1F1C2B7; Wed, 5 Feb 2020 17:53:22 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 13BCE1C2A2 for ; Wed, 5 Feb 2020 17:53:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 08:53:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,406,1574150400"; d="scan'208";a="378794044" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.61]) ([10.237.221.61]) by orsmga004.jf.intel.com with ESMTP; 05 Feb 2020 08:53:17 -0800 To: =?UTF-8?Q?J=c3=balius_Milan?= Cc: dev@dpdk.org, jgrajcia@cisco.com References: <20200205154133.GA16794@vbox> <20200205164405.GA26554@vbox> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <68844faf-9d42-ea58-3404-d7e0fd454b93@intel.com> Date: Wed, 5 Feb 2020 16:53:14 +0000 MIME-Version: 1.0 In-Reply-To: <20200205164405.GA26554@vbox> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/memif: enable loopback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/5/2020 4:44 PM, Július Milan wrote: > On Wed, Feb 05, 2020 at 04:00:19PM +0000, Ferruh Yigit wrote: >> On 2/5/2020 3:41 PM, Július Milan wrote: >>> With this patch it is possible to connect 2 DPDK memifs into loopback, >>> i.e. when they have the same id and different roles, as for example: >>> "--vdev=net_memif0,role=master,id=0" >>> "--vdev=net_memif1,role=slave,id=0" >> >> Overall looks good idea but this cause a crash in testpmd on exit, can you >> please check? >> > Thank you, > Do you mean this message? > "EAL: Error: Invalid memory" No. > If not, how can I reproduce it? Start testpmd [1], quit it [2], and will get a crash [3]. Full log in [4]. [1] ./build/app/testpmd --no-pci --vdev=net_memif0,role=master,id=0 --vdev=net_memif1,role=slave,id=0 --vdev=net_memif1,role=slave,id=1 --log-level "pmd*:debug" -- --no-mlockall -i [2] testpmd> quit [3] Segmentation fault (core dumped) [4] $ ./build/app/testpmd --no-pci --vdev=net_memif0,role=master,id=0 --vdev=net_memif1,role=slave,id=0 --vdev=net_memif1,role=slave,id=1 --log-level "pmd*:debug" -- --no-mlockall -i EAL: Detected 96 lcore(s) EAL: Detected 2 NUMA nodes EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'PA' EAL: Probing VFIO support... EAL: VFIO support initialized rte_pmd_memif_probe(): Initialize MEMIF: net_memif0. memif_socket_create(): Memif listener socket /run/memif.sock created. rte_pmd_memif_probe(): Initialize MEMIF: net_memif1. Interactive-mode selected Warning: NUMA should be configured manually by using --port-numa-config and --ring-numa-config parameters along with --numa. testpmd: create a new mbuf pool : n=779456, size=2176, socket=0 testpmd: preferred mempool ops selected: ring_mp_mc testpmd: create a new mbuf pool : n=779456, size=2176, socket=1 testpmd: preferred mempool ops selected: ring_mp_mc Configuring Port 0 (socket 0) Port 0: 3A:45:AA:E6:9A:93 Configuring Port 1 (socket 0) memif_listener_handler(): /run/memif.sock: Connection request accepted. memif_msg_send_from_queue(): Sent msg type 2. memif_connect_slave(): Memif socket: /run/memif.sock connected. memif_msg_receive(): Received msg type: 2. memif_msg_receive_hello(): Connecting to DPDK 20.02.0-rc1. memif_msg_send_from_queue(): Sent msg type 3. memif_msg_receive(): Received msg type: 3. memif_msg_send_from_queue(): Sent msg type 1. memif_msg_receive(): Received msg type: 1. memif_msg_send_from_queue(): Sent msg type 4. memif_msg_receive(): Received msg type: 4. memif_msg_send_from_queue(): Sent msg type 1. memif_msg_receive(): Received msg type: 1. memif_msg_send_from_queue(): Sent msg type 5. memif_msg_receive(): Received msg type: 5. memif_msg_send_from_queue(): Sent msg type 1. memif_msg_receive(): Received msg type: 1. memif_msg_send_from_queue(): Sent msg type 5. memif_msg_receive(): Received msg type: 5. memif_msg_send_from_queue(): Sent msg type 1. memif_msg_receive(): Received msg type: 1. memif_msg_send_from_queue(): Sent msg type 6. memif_msg_receive(): Received msg type: 6. memif_connect(): Connected. memif_msg_receive_connect(): Remote interface net_memif1 connected. memif_msg_send_from_queue(): Sent msg type 7. memif_msg_receive(): Received msg type: 7. memif_connect(): Connected. memif_msg_receive_connected(): Remote interface net_memif0 connected. Port 1: BA:50:9A:75:5E:9F Checking link statuses... Done Error during enabling promiscuous mode for port 0: Operation not supported - ignore Error during enabling promiscuous mode for port 1: Operation not supported - ignore testpmd> quit Stopping port 0... Stopping ports... Done Stopping port 1... Stopping ports... Done Shutting down port 0... Closing ports... memif_msg_receive(): Received msg type: 8. memif_msg_receive_disconnect(): Disconnect received: Device closed memif_disconnect(): Disconnected. memif_msg_receive(): Invalid message size. memif_msg_send_from_queue(): sendmsg fail: Broken pipe. memif_disconnect(): Unexpected message(s) in message queue. memif_disconnect(): Disconnected. memif_msg_send_from_queue(): Sent msg type 0. Segmentation fault (core dumped) > >>> >>> Fixes: 09c7e63a71 ("net/memif: introduce memory interface PMD") >>> >>> Signed-off-by: Július Milan >>> --- >>> drivers/net/memif/memif_socket.c | 17 ++++------------- >>> 1 file changed, 4 insertions(+), 13 deletions(-) >>> >>> diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c >>> index ad5e30b96..552d3bec1 100644 >>> --- a/drivers/net/memif/memif_socket.c >>> +++ b/drivers/net/memif/memif_socket.c >>> @@ -203,7 +203,7 @@ memif_msg_receive_init(struct memif_control_channel *cc, memif_msg_t *msg) >>> dev = elt->dev; >>> pmd = dev->data->dev_private; >>> if (((pmd->flags & ETH_MEMIF_FLAG_DISABLED) == 0) && >>> - pmd->id == i->id) { >>> + (pmd->id == i->id) && (pmd->role == MEMIF_ROLE_MASTER)) { >>> /* assign control channel to device */ >>> cc->dev = dev; >>> pmd->cc = cc; >>> @@ -965,20 +965,11 @@ memif_socket_init(struct rte_eth_dev *dev, const char *socket_filename) >>> } >>> pmd->socket_filename = socket->filename; >>> >>> - if (socket->listener != 0 && pmd->role == MEMIF_ROLE_SLAVE) { >>> - MIF_LOG(ERR, "Socket is a listener."); >>> - return -1; >>> - } else if ((socket->listener == 0) && (pmd->role == MEMIF_ROLE_MASTER)) { >>> - MIF_LOG(ERR, "Socket is not a listener."); >>> - return -1; >>> - } >>> - >>> TAILQ_FOREACH(elt, &socket->dev_queue, next) { >>> tmp_pmd = elt->dev->data->dev_private; >>> - if (tmp_pmd->id == pmd->id) { >>> - MIF_LOG(ERR, "Memif device with id %d already " >>> - "exists on socket %s", >>> - pmd->id, socket->filename); >>> + if (tmp_pmd->id == pmd->id && tmp_pmd->role == pmd->role) { >>> + MIF_LOG(ERR, "Two interfaces with the same id (%d) can " >>> + "not have the same role.", pmd->id); >>> return -1; >>> } >>> } >>> >>