From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8994A0613 for ; Thu, 26 Sep 2019 20:51:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A74BB2C38; Thu, 26 Sep 2019 20:51:31 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8E8452C37 for ; Thu, 26 Sep 2019 20:51:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 11:51:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,553,1559545200"; d="scan'208";a="196469318" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by FMSMGA003.fm.intel.com with ESMTP; 26 Sep 2019 11:51:26 -0700 To: Xiaoyun wang Cc: dev@dpdk.org, xuanziyang2@huawei.com, shahar.belkar@huawei.com, luoxianjun@huawei.com, tanya.brokhman@huawei.com, zhouguoyang@huawei.com, wulike1@huawei.com References: <469930b5fd3908240c5a04affaf62faf51b49a2d.1569421287.git.cloud.wangxiaoyun@huawei.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <6885e6b4-cce5-506f-095e-4f94c9ce3310@intel.com> Date: Thu, 26 Sep 2019 19:51:23 +0100 MIME-Version: 1.0 In-Reply-To: <469930b5fd3908240c5a04affaf62faf51b49a2d.1569421287.git.cloud.wangxiaoyun@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 15/17] net/hinic: add hinic PMD doc files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/25/2019 3:30 PM, Xiaoyun wang wrote: > Add doc files about new features and modification. > > Signed-off-by: Xiaoyun wang > --- > doc/guides/nics/features/hinic.ini | 12 ++++++++- > doc/guides/nics/hinic.rst | 6 +++++ > doc/guides/rel_notes/release_19_11.rst | 45 ++++++---------------------------- > 3 files changed, 25 insertions(+), 38 deletions(-) > > diff --git a/doc/guides/nics/features/hinic.ini b/doc/guides/nics/features/hinic.ini > index fe063d6..dc02b4b 100644 > --- a/doc/guides/nics/features/hinic.ini > +++ b/doc/guides/nics/features/hinic.ini > @@ -9,16 +9,22 @@ Link status = Y > Link status event = Y > Free Tx mbuf on demand = Y > Queue start/stop = Y > -Jumbo frame = N > +MTU update = Y > +Jumbo frame = Y > Scattered Rx = Y > TSO = Y > +LRO = Y > Promiscuous mode = Y > +Allmulticast mode = Y > Unicast MAC filter = Y > Multicast MAC filter = Y > RSS hash = Y > RSS key update = Y > RSS reta update = Y > Inner RSS = Y > +SR-IOV = Y > +VLAN filter = Y > +VLAN offload = Y > CRC offload = Y > L3 checksum offload = Y > L4 checksum offload = Y > @@ -27,6 +33,10 @@ Inner L4 checksum = Y > Basic stats = Y > Extended stats = Y > Stats per queue = Y > +Flow director = Y > +Flow control = Y > +FW version = Y > +Multiprocess aware = Y > Linux UIO = Y > Linux VFIO = Y > BSD nic_uio = N > diff --git a/doc/guides/nics/hinic.rst b/doc/guides/nics/hinic.rst > index c9329bc..f036fc5 100644 > --- a/doc/guides/nics/hinic.rst > +++ b/doc/guides/nics/hinic.rst > @@ -24,6 +24,12 @@ Features > - Link state information > - Link flow control > - Scattered and gather for TX and RX > +- SR�CIOV - Partially supported at this point, VFIO only Can you fix the char is SR-IOV? > +- Allmulticast mode > +- Unicast MAC filter > +- Multicast MAC filter > +- FW version > +- Flow director > > Prerequisites > ------------- > diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst > index 65361c4..6c6f27f 100644 > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -56,11 +56,15 @@ New Features > Also, make sure to start the actual text at the margin. > ========================================================= > > -* **Updated the Intel ice driver.** > +* **Updated the Huawei hinic driver.** > > - Updated the Intel ice driver with new features and improvements, including: > + Updated the Huawei hinic driver with new features and improvements, including: > > - * Added support for device-specific DDP package loading. > + * Enabled SR-IOV - Partially supported at this point, VFIO only. > + * Supported VLAN filter and VLAN offload. > + * Supported Unicast MAC filter and Multicast MAC filter. > + * Supported FW version get. > + * Supported Flow director for LACP, VRRP, BGP and so on. Can you please distribute the doc patches in to the related patches that introduces the feature, for all three document, it helps by documenting what has been added in the patch. > > Removed Items > ------------- > @@ -99,30 +103,6 @@ API Changes > Also, make sure to start the actual text at the margin. > ========================================================= > > -* ethdev: changed ``rte_eth_dev_infos_get`` return value from ``void`` to > - ``int`` to provide a way to report various error conditions. > - > -* ethdev: changed ``rte_eth_promiscuous_enable`` and > - ``rte_eth_promiscuous_disable`` return value from ``void`` to ``int`` to > - provide a way to report various error conditions. > - > -* ethdev: changed ``rte_eth_allmulticast_enable`` and > - ``rte_eth_allmulticast_disable`` return value from ``void`` to ``int`` to > - provide a way to report various error conditions. > - > -* ethdev: changed ``rte_eth_dev_xstats_reset`` return value from ``void`` to > - ``int`` to provide a way to report various error conditions. > - > -* ethdev: changed ``rte_eth_link_get`` and ``rte_eth_link_get_nowait`` > - return value from ``void`` to ``int`` to provide a way to report various > - error conditions. > - > -* ethdev: changed ``rte_eth_macaddr_get`` return value from ``void`` to > - ``int`` to provide a way to report various error conditions. > - > -* ethdev: changed ``rte_eth_dev_owner_delete`` return value from ``void`` to > - ``int`` to provide a way to report various error conditions. > - > > ABI Changes > ----------- > @@ -174,7 +154,7 @@ The libraries prepended with a plus sign were incremented in this version. > librte_distributor.so.1 > librte_eal.so.11 > librte_efd.so.1 > - + librte_ethdev.so.13 > + librte_ethdev.so.12 > librte_eventdev.so.7 > librte_flow_classify.so.1 > librte_gro.so.1 > @@ -252,12 +232,3 @@ Tested Platforms > Also, make sure to start the actual text at the margin. > ========================================================= > > -* **Updated Mellanox mlx5 driver.** > - > - Updated Mellanox mlx5 driver with new features and improvements, including: > - > - * Added support for VLAN pop flow offload command. > - * Added support for VLAN push flow offload command. > - * Added support for VLAN set PCP offload command. > - * Added support for VLAN set VID offload command. > - > I guess above changes are git mistake, please check in next version.