* [dpdk-dev] [PATCH] net/ixgbe: remove unnecessary macro
@ 2018-05-22 12:47 Qi Zhang
2018-05-22 13:38 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Qi Zhang @ 2018-05-22 12:47 UTC (permalink / raw)
To: ferruh.yigit; +Cc: wei.dai, wenzhuo.lu, dev, Qi Zhang
Since we move to new offload APIs, IXGBE_SIMPLE_FLAGS is not used.
Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ixgbe/ixgbe_rxtx.h | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h
index 20ef7b6ff..39378f754 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.h
+++ b/drivers/net/ixgbe/ixgbe_rxtx.h
@@ -241,20 +241,6 @@ struct ixgbe_txq_ops {
};
/*
- * The "simple" TX queue functions require that the following
- * flags are set when the TX queue is configured:
- * - ETH_TXQ_FLAGS_NOMULTSEGS
- * - ETH_TXQ_FLAGS_NOVLANOFFL
- * - ETH_TXQ_FLAGS_NOXSUMSCTP
- * - ETH_TXQ_FLAGS_NOXSUMUDP
- * - ETH_TXQ_FLAGS_NOXSUMTCP
- * and that the RS bit threshold (tx_rs_thresh) is at least equal to
- * RTE_PMD_IXGBE_TX_MAX_BURST.
- */
-#define IXGBE_SIMPLE_FLAGS ((uint32_t)ETH_TXQ_FLAGS_NOMULTSEGS | \
- ETH_TXQ_FLAGS_NOOFFLOADS)
-
-/*
* Populate descriptors with the following info:
* 1.) buffer_addr = phys_addr + headroom
* 2.) cmd_type_len = DCMD_DTYP_FLAGS | pkt_len
--
2.13.6
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: remove unnecessary macro
2018-05-22 12:47 [dpdk-dev] [PATCH] net/ixgbe: remove unnecessary macro Qi Zhang
@ 2018-05-22 13:38 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-05-22 13:38 UTC (permalink / raw)
To: Qi Zhang; +Cc: wei.dai, wenzhuo.lu, dev
On 5/22/2018 1:47 PM, Qi Zhang wrote:
> Since we move to new offload APIs, IXGBE_SIMPLE_FLAGS is not used.
Documentation also mentions from this flag, can you update there too?
>
> Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
<...>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-22 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 12:47 [dpdk-dev] [PATCH] net/ixgbe: remove unnecessary macro Qi Zhang
2018-05-22 13:38 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).