DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pashupati Kumar <kumarp@Brocade.COM>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] RTE CRC hash function
Date: Mon, 9 Dec 2013 19:17:48 -0800	[thread overview]
Message-ID: <6895EAE0CA8DEE40B92D7CA88BB521F332BA572FC0@HQ1-EXCH02.corp.brocade.com> (raw)

Hi,
I am looking at the DPDK implementation for  the CRC hash function using Intel intrinsics.  Shouldn't the order of the arguments being passed to  _mm_crc32_u32 be reversed ?
http://dpdk.org/doc/api/rte__hash__crc_8h.html

For a quick reference, here is the code with Actual and Modified calls.
static inline uint32_t
rte_hash_crc_4byte(uint32_t data, uint32_t init_val)
{
	Actual > return _mm_crc32_u32(data, init_val);
	Modified > return _mm_crc32_u32(init_val, data);
}


Thanks
Pash

             reply	other threads:[~2013-12-10  3:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10  3:17 Pashupati Kumar [this message]
2014-02-26  9:07 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6895EAE0CA8DEE40B92D7CA88BB521F332BA572FC0@HQ1-EXCH02.corp.brocade.com \
    --to=kumarp@brocade.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).