From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kumarp@Brocade.COM>
Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com
 [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id B3447682E
 for <dev@dpdk.org>; Tue, 10 Dec 2013 04:16:50 +0100 (CET)
Received: from pps.filterd (m0000542 [127.0.0.1])
 by mx0a-000f0801.pphosted.com (8.14.5/8.14.5) with SMTP id rBA2KHpq030580
 for <dev@dpdk.org>; Mon, 9 Dec 2013 19:17:51 -0800
Received: from hq1wp-exchub01.corp.brocade.com ([144.49.131.13])
 by mx0a-000f0801.pphosted.com with ESMTP id 1gmwxvss19-1
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT)
 for <dev@dpdk.org>; Mon, 09 Dec 2013 19:17:51 -0800
Received: from HQ1WP-EXHUB01.corp.brocade.com (10.70.36.14) by
 HQ1WP-EXCHUB01.corp.brocade.com (10.70.36.99) with Microsoft SMTP Server
 (TLS) id 14.3.123.3; Mon, 9 Dec 2013 19:17:50 -0800
Received: from HQ1-EXCH02.corp.brocade.com ([fe80::c92a:772e:befa:c34c]) by
 HQ1WP-EXHUB01.corp.brocade.com ([::1]) with mapi; Mon, 9 Dec 2013 19:17:48
 -0800
From: Pashupati Kumar <kumarp@Brocade.COM>
To: "dev@dpdk.org" <dev@dpdk.org>
Date: Mon, 9 Dec 2013 19:17:48 -0800
Thread-Topic: RTE CRC hash function
Thread-Index: Ac71VijSnvV7PRjFT8mX5DHrVtlRbg==
Message-ID: <6895EAE0CA8DEE40B92D7CA88BB521F332BA572FC0@HQ1-EXCH02.corp.brocade.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.72, 1.0.14,
 0.0.0000
 definitions=2013-12-10_01:2013-12-10,2013-12-10,1970-01-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
 suspectscore=0 phishscore=0
 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=7.0.1-1305240000 definitions=main-1312090215
Subject: [dpdk-dev] RTE CRC hash function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Dec 2013 03:16:51 -0000

Hi,
I am looking at the DPDK implementation for  the CRC hash function using In=
tel intrinsics.  Shouldn't the order of the arguments being passed to  _mm_=
crc32_u32 be reversed ?
http://dpdk.org/doc/api/rte__hash__crc_8h.html

For a quick reference, here is the code with Actual and Modified calls.
static inline uint32_t
rte_hash_crc_4byte(uint32_t data, uint32_t init_val)
{
	Actual > return _mm_crc32_u32(data, init_val);
	Modified > return _mm_crc32_u32(init_val, data);
}


Thanks
Pash