From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 7DC6D1F1C for ; Tue, 22 May 2018 14:37:33 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1537181663D3; Tue, 22 May 2018 12:37:33 +0000 (UTC) Received: from [10.36.112.17] (ovpn-112-17.ams2.redhat.com [10.36.112.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 57E0D215CDA7; Tue, 22 May 2018 12:37:32 +0000 (UTC) To: Tiwei Bie Cc: dev@dpdk.org, ferruh.yigit@intel.com References: <20180522122211.26627-1-maxime.coquelin@redhat.com> <20180522123403.GA28178@debian> From: Maxime Coquelin Message-ID: <689f34b6-e99f-a196-afa3-71f32d589437@redhat.com> Date: Tue, 22 May 2018 14:37:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180522123403.GA28178@debian> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 22 May 2018 12:37:33 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 22 May 2018 12:37:33 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v2] net/vhost: convert to new Rx/Tx offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 12:37:33 -0000 On 05/22/2018 02:34 PM, Tiwei Bie wrote: > On Tue, May 22, 2018 at 02:22:11PM +0200, Maxime Coquelin wrote: >> Signed-off-by: Maxime Coquelin >> --- >> Changes since v2: >> - Announce supported Rx & Tx offload features (Tiwei) >> >> drivers/net/vhost/rte_eth_vhost.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c >> index f473bbbb3..229a5ba8d 100644 >> --- a/drivers/net/vhost/rte_eth_vhost.c >> +++ b/drivers/net/vhost/rte_eth_vhost.c >> @@ -491,9 +491,9 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused) >> struct pmd_internal *internal = dev->data->dev_private; >> const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; >> >> - internal->vlan_strip = rxmode->hw_vlan_strip; >> + internal->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP); >> >> - if (rxmode->hw_vlan_filter) >> + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) >> VHOST_LOG(WARNING, >> "vhost(%s): vlan filtering not available\n", >> internal->dev_name); > > I'm not quite sure whether we still need to log this warning. In theory we should not. But currently, my understanding is that no error is returned in the current release (see lib/librte_ethdev/rte_ethdev.c:1174). I think we can remove it in next release. >> @@ -1072,6 +1072,10 @@ eth_dev_info(struct rte_eth_dev *dev, >> dev_info->max_rx_queues = internal->max_queues; >> dev_info->max_tx_queues = internal->max_queues; >> dev_info->min_rx_bufsize = 0; >> + >> + dev_info->tx_offload_capa = DEV_TX_OFFLOAD_MULTI_SEGS | >> + DEV_TX_OFFLOAD_VLAN_INSERT; >> + dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP; >> } > > Other than that, it looks good to me. Thanks! Thanks for the review. Maxime > Best regards, > Tiwei Bie >