From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <marcinx.kerlin@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 04AC59AAC
 for <dev@dpdk.org>; Mon, 20 Jun 2016 13:11:50 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga101.fm.intel.com with ESMTP; 20 Jun 2016 04:11:50 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,498,1459839600"; d="scan'208";a="1001470626"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by orsmga002.jf.intel.com with ESMTP; 20 Jun 2016 04:11:49 -0700
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.10]) by
 irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0248.002;
 Mon, 20 Jun 2016 12:11:48 +0100
From: "Kerlin, MarcinX" <marcinx.kerlin@intel.com>
To: "'johndale@cisco.com'" <johndale@cisco.com>, "'neescoba@cisco.com'"
 <neescoba@cisco.com>
CC: "'dev@dpdk.org'" <dev@dpdk.org>
Thread-Topic: unchecked return value in enic driver
Thread-Index: AdHFZTPCoxBaRpidQCOMNdU6UvbsiAFfdb1Q
Date: Mon, 20 Jun 2016 11:11:47 +0000
Message-ID: <68D830D942438745AD09BAFA99E33E8125F85F@IRSMSX102.ger.corp.intel.com>
References: <68D830D942438745AD09BAFA99E33E8125DFA8@IRSMSX102.ger.corp.intel.com>
In-Reply-To: <68D830D942438745AD09BAFA99E33E8125DFA8@IRSMSX102.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] unchecked return value in enic driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jun 2016 11:11:51 -0000

Hi John and Nelson,

> -----Original Message-----
> From: Kerlin, MarcinX
> Sent: Monday, June 13, 2016 1:18 PM
> To: johndale@cisco.com; neescoba@cisco.com
> Cc: dev@dpdk.org
> Subject: unchecked return value in enic driver
>=20
> Hi John and Nelson,
>=20
> I have a question regarding Coverity defects:
>=20
> File: /drivers/net/enic/enic_ethdev.c
> Line: 379
>=20
> CID 13197: Unchecked return value
> (CHECKED_RETURN)1.=A0check_return:=A0Calling=A0rte_atomic64_cmpset=A0with=
out
> checking return value (as is done elsewhere 15 out of 17 times)
>=20
> Can I mark this error as "False Positive" in Coverity Classification ? re=
ason:
> 1. Function returns a void type so change the return type to int requires
> changes all drivers 2. rte_atomic64_cmpset is at the end of function so
> nonsense added a return
>=20
> What is your opinion?

I marked this Coverity as false-positive with an explanation. If in your op=
inion it is not ok, you can reopen/change/fix it.

>=20
> Regards,
> Marcin