From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0C26F5679 for ; Wed, 28 Sep 2016 13:35:15 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP; 28 Sep 2016 04:35:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,409,1470726000"; d="scan'208";a="14094638" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga005.fm.intel.com with ESMTP; 28 Sep 2016 04:35:14 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.198]) by IRSMSX107.ger.corp.intel.com ([169.254.10.95]) with mapi id 14.03.0248.002; Wed, 28 Sep 2016 12:34:32 +0100 From: "Kerlin, MarcinX" To: "Pattan, Reshma" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" , "thomas.monjalon@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v4 2/2] app/testpmd: improve handling of multiprocess Thread-Index: AQHSGXccYDdHpkOzr067XYl1VHBSwqCOxEPg Date: Wed, 28 Sep 2016 11:34:32 +0000 Message-ID: <68D830D942438745AD09BAFA99E33E812BD517@IRSMSX102.ger.corp.intel.com> References: <1474901586-8706-2-git-send-email-marcinx.kerlin@intel.com> <1474974783-4861-1-git-send-email-marcinx.kerlin@intel.com> <1474974783-4861-3-git-send-email-marcinx.kerlin@intel.com> <3AEA2BF9852C6F48A459DA490692831F010A9088@IRSMSX109.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F010A9088@IRSMSX109.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: improve handling of multiprocess X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2016 11:35:16 -0000 Hi > -----Original Message----- > From: Pattan, Reshma > Sent: Wednesday, September 28, 2016 12:58 PM > To: Kerlin, MarcinX ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > thomas.monjalon@6wind.com; Kerlin, MarcinX > Subject: RE: [dpdk-dev] [PATCH v4 2/2] app/testpmd: improve handling of > multiprocess >=20 > Hi, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marcin Kerlin > > Sent: Tuesday, September 27, 2016 12:13 PM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; > > thomas.monjalon@6wind.com; Kerlin, MarcinX > > Subject: [dpdk-dev] [PATCH v4 2/2] app/testpmd: improve handling of > > multiprocess > > >=20 > Check patch issues for lines over 80. Please run check patch for next ver= sions >=20 > WARNING:LONG_LINE: line over 80 characters > #40: FILE: app/test-pmd/testpmd.c:457: > + rte_mp =3D > + rte_pktmbuf_pool_create(pool_name, nb_mbuf, >=20 > WARNING:LONG_LINE: line over 80 characters > #41: FILE: app/test-pmd/testpmd.c:458: > + mb_mempool_cache, 0, > + mbuf_seg_size, socket_id); >=20 > total: 0 errors, 2 warnings, 61 lines checked I did checkpatch test before and everything is fine if you look to source c= ode.=20 Checkpatch interprets tab as 8 chars but should as 4. Everything is in the = 80 characters. Regards, Marcin >=20 > Thanks, > Reshma