From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97283A0524; Fri, 27 Nov 2020 11:07:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78058C938; Fri, 27 Nov 2020 11:07:37 +0100 (CET) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by dpdk.org (Postfix) with ESMTP id 1B332C92A for ; Fri, 27 Nov 2020 11:07:36 +0100 (CET) Received: by mail-wm1-f48.google.com with SMTP id 3so2247229wmg.4 for ; Fri, 27 Nov 2020 02:07:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=RyzTdVgjESMRgbfC7ILpzNL4mw3I2RKTXCUvng4ZePs=; b=DiUAGaNU/fNXOtoQNsxikHZFGOfwCpfS67HAjoIt6cv+nca252dVx9qY40LSXG6aBW tThtvh/IRvffRV+dQgDM1s8yOkQ0hJKkxiXJAwmxQAOrG9hk7KEAoinT96GcQOOihqck uPNVIYIJI5aEgUznTEI8cZeBFTgCMGBp/sdAen0x0Wt4v54Xt0pPdjobgwq3gFgjxhwa cNLFG3fMzpOc5xJxj3McPTgch4w1RgngsnzCg53IyVegXAhOO9f+mWSXrZBcBCqSM0NY HpbV1CT1FrkQB2aJvP2D5H+O2IyT/nfNG3HgsJiTDZxuWKP5qETbK/MgKUorS26+x0nF m8HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=RyzTdVgjESMRgbfC7ILpzNL4mw3I2RKTXCUvng4ZePs=; b=j1RS5H2Aw0zWppnngFCqRNv0KfozrxVEoVkOyc+I5mzsXF4qqklyAUs4xEplG6f+Ao A6MAYdsU7lI6m+C6KR93wCt/yJgz9DFN9YIFaSiJzkx6hN42IpFBPzPggtnNX3kYD+3Z gCu78wy2nPyHRQy9wZ3rbV21qjEBs1SBnEx7khhlb+2GrS0qmCl3L3dLtoUZW02OWfIw zyPLHkcyXZxcGfhPL+NWIFAb0ct360q1iSIKSL82LYX5QcKO6qGzuzQoFZZPQfWli75g KJhG4ME0VmqqAi1EPUuU/1d5dH0TMHl1bKWr85RiBs2DwzkhUXErc+l3zdztIYZOrmza tTlg== X-Gm-Message-State: AOAM533moD4k0E0Zf83pE6jBfeuCFqyLrMROCRPqHBGXuhu/VK9JwDXD wQTPU0ILDPQWxAGllhBBR37+GQ== X-Google-Smtp-Source: ABdhPJxJHP1a/xt3lblt3gdUtvetyGSL7n1kZBo/2WrPnDaDQdSWT4bHZkTBKYi4gg/HtbegY2Shvg== X-Received: by 2002:a7b:c3ce:: with SMTP id t14mr8026169wmj.170.1606471654824; Fri, 27 Nov 2020 02:07:34 -0800 (PST) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id c5sm14024253wrb.64.2020.11.27.02.07.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Nov 2020 02:07:34 -0800 (PST) From: Nick Connolly X-Google-Original-From: Nick Connolly To: David Marchand , Pallavi Kadam , Bruce Richardson Cc: dev , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , "Dmitry Malloy (MESHCHANINOV)" References: <91117f53-99a5-e427-3e7f-162dda832b8b@mayadata.io> Message-ID: <68b89ead-32f1-bd69-d690-a0ed564fbd20@mayadata.io> Date: Fri, 27 Nov 2020 10:07:31 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <91117f53-99a5-e427-3e7f-162dda832b8b@mayadata.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [dpdk-dev] Build error with mingw in debug mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Errata: the definition is in rte_os.h rather than rte_windows.h On 27/11/2020 10:05, Nick Connolly wrote: > The root cause here is that rte_windows.h shouldn't be injecting > 'missing' POSIX functionality > into the environment.  The header is included indirectly in > application code via rte_os.h, but > deciding how to implement the 'missing' functionality should be the > applications responsibility. > > There are a number of definitions that fall in this category, so there > will need to be some work > done to resolve the issues. > > In the meantime, I'll prepare a patch that works around the specific > issue you've encountered. > > Regards, > Nick > > On 27/11/2020 09:53, David Marchand wrote: >> This is introduced by e8428a9d89f1 ("eal/windows: add some basic >> functions and macros"). >> So sending to you guys: >> >> Caught while compiling all my envs with --buildtype=debug rather than >> debugoptimized: >> >> ninja: Entering directory `/home/dmarchan/builds/build-x86-mingw' >> ... >> Build targets in project: 70 >> Option buildtype is: debug [default: release] >> Found ninja-1.9.0 at /usr/bin/ninja >> [1/149] Compiling C object >> 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj'. >> FAILED: >> lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj >> x86_64-w64-mingw32-gcc -Ilib/76b5a35@@rte_eal@sta -Ilib >> -I../../dpdk/lib -I. -I../../dpdk/ -Iconfig -I../../dpdk/config >> -Ilib/librte_eal/include -I../../dpdk/lib/librte_eal/include >> -Ilib/librte_eal/windows/include >> -I../../dpdk/lib/librte_eal/windows/include >> -Ilib/librte_eal/x86/include -I../../dpdk/lib/librte_eal/x86/include >> -Ilib/librte_eal/common -I../../dpdk/lib/librte_eal/common >> -Ilib/librte_eal -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs >> -I../../dpdk/lib/librte_kvargs -fdiagnostics-color=always -pipe -Wall >> -Winvalid-pch -Werror -g -include rte_config.h -Wextra -Wcast-qual >> -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security >> -Wmissing-declarations -Wmissing-prototypes -Wnested-externs >> -Wold-style-definition -Wpointer-arith -Wsign-compare >> -Wstrict-prototypes -Wundef -Wwrite-strings >> -Wno-address-of-packed-member -Wno-packed-not-aligned >> -Wno-missing-field-initializers -D_GNU_SOURCE -D_WIN32_WINNT=0x0A00 >> -D__USE_MINGW_ANSI_STDIO -march=native -DALLOW_EXPERIMENTAL_API >> -DALLOW_INTERNAL_API -Wno-format-truncation '-DABI_VERSION="21.0"' -MD >> -MQ >> 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj' >> -MF >> 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj.d' >> -o 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj' >> -c ../../dpdk/lib/librte_eal/common/eal_common_hexdump.c >> In file included from ../../dpdk/lib/librte_eal/include/rte_common.h:28, >>                   from >> ../../dpdk/lib/librte_eal/include/rte_string_fns.h:21, >>                   from >> ../../dpdk/lib/librte_eal/common/eal_common_hexdump.c:9: >> ../../dpdk/lib/librte_eal/windows/include/rte_os.h:40: error: >> "strncasecmp" redefined [-Werror] >>     40 | #define strncasecmp(s1, s2, count)        _strnicmp(s1, s2, >> count) >>        | >> In file included from >> ../../dpdk/lib/librte_eal/include/rte_string_fns.h:19, >>                   from >> ../../dpdk/lib/librte_eal/common/eal_common_hexdump.c:9: >> /usr/x86_64-w64-mingw32/sys-root/mingw/include/string.h:119: note: >> this is the location of the previous definition >>    119 | #define strncasecmp _strnicmp >>        | >> cc1: all warnings being treated as errors >> >> >