From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 783B9DED; Fri, 4 May 2018 11:30:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2018 02:29:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,361,1520924400"; d="scan'208";a="52364039" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.18.186]) ([10.252.18.186]) by fmsmga001.fm.intel.com with ESMTP; 04 May 2018 02:29:58 -0700 To: Gowrishankar , Sergio Gonzalez Monroy Cc: dev@dpdk.org, Thomas Monjalon , stable@dpdk.org References: From: "Burakov, Anatoly" Message-ID: <68d1bc7b-a90d-2adc-c98b-560276589b15@intel.com> Date: Fri, 4 May 2018 10:29:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] eal/malloc: merge malloc_elems in heap if they are contiguous X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 09:30:01 -0000 On 03-May-18 11:11 AM, Gowrishankar wrote: > From: Gowrishankar Muthukrishnan > > During malloc heap init, if there are malloc_elems contiguous in > virt addresses, they could be merged so that, merged malloc_elem > would guarantee larger free memory size than its actual hugepage > size, it was created for. > > Fixes: fafcc11985 ("mem: rework memzone to be allocated by malloc") > Cc: stable@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan > --- Hi Gowrishankar, I haven't looked at the patchset in detail yet, however i have a general question: how do we end up with VA-contiguous memsegs that are not part of the same memseg in the first place? Is there something wrong with memseg sorting code? Alternatively, if they were broken up, presumably they were broken up for a reason, namely while they may be VA contiguous, they weren't IOVA-contiguous. Can you provide a dump of physmem layout where memory would have been VA and IOVA-contiguous while belonging to different memsegs? -- Thanks, Anatoly