From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE6C4A00C5; Tue, 1 Feb 2022 09:21:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9318B40691; Tue, 1 Feb 2022 09:21:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D58DE40685 for ; Tue, 1 Feb 2022 09:21:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643703677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+qZ8cD4w16j80Je4DqJ+bic0FNO2WESR/BkQuqIVTg8=; b=Q8iiLmbAnDqHoMfVzIDPi+Wnx1nCkjpRaKOAI+puR/ym1ja2B1WQ/ILZ78zLylXxL0ni2k JXJNFUB645aoEBmCRYCN1uO/6lemcdKyZeCqjQgPCNQ/WmGR57H+ZLTxqThfYf+ulv+yQz ZBOpBrgaIMBTURFWZEIvt5i9Uza47zA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-398-jFWDD1GhMY6H_uIgzwBnQQ-1; Tue, 01 Feb 2022 03:21:14 -0500 X-MC-Unique: jFWDD1GhMY6H_uIgzwBnQQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C668A84DA40; Tue, 1 Feb 2022 08:21:12 +0000 (UTC) Received: from [10.39.208.24] (unknown [10.39.208.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FB9C106F960; Tue, 1 Feb 2022 08:21:10 +0000 (UTC) Message-ID: <68d64efb-a861-219a-ce02-d6a0199389c1@redhat.com> Date: Tue, 1 Feb 2022 09:21:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] vdpa/sfc: make MCDI memzone name unique To: abhimanyu.saini@xilinx.com, dev@dpdk.org Cc: chenbo.xia@intel.com, andrew.rybchenko@oktetlabs.ru, vsrivast@xilinx.com, Abhimanyu Saini References: <20220111053303.18162-1-asaini@xilinx.com> <20220117112906.23823-1-asaini@xilinx.com> From: Maxime Coquelin In-Reply-To: <20220117112906.23823-1-asaini@xilinx.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Abhimanyu, On 1/17/22 12:29, abhimanyu.saini@xilinx.com wrote: > From: Abhimanyu Saini > > Buffer for MCDI channel is allocated using rte_memzone_reserve_aligned > with zone name 'mcdi'. Since multiple MCDI channels are needed to > support multiple VF(s) and rte_memzone_reserve_aligned expects unique > zone names, append PCI address to zone name to make it unique. > > Signed-off-by: Abhimanyu Saini > --- > v2: > * Formatting changes > > drivers/vdpa/sfc/sfc_vdpa_hw.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > The patch itself looks goof to me, but it seems you have issues with its formatting (I guess you need to configure indents properly in your editor): WARNING:LEADING_SPACE: please, no spaces at the start of a line #153: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:28: + char mz_name[RTE_MEMZONE_NAMESIZE];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #159: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:34: + ret = snprintf(mz_name, RTE_MEMZONE_NAMESIZE, "%s_%s",$ ERROR:CODE_INDENT: code indent should use tabs where possible #160: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:35: + sva->pdev->name, name);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #160: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:35: + sva->pdev->name, name);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #161: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:36: + if (ret < 0 || ret >= RTE_MEMZONE_NAMESIZE) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #161: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:36: + if (ret < 0 || ret >= RTE_MEMZONE_NAMESIZE) { + sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name", ERROR:CODE_INDENT: code indent should use tabs where possible #162: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:37: + sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #162: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:37: + sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",$ ERROR:CODE_INDENT: code indent should use tabs where possible #163: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:38: + sva->pdev->name, name);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #163: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:38: + sva->pdev->name, name);$ ERROR:CODE_INDENT: code indent should use tabs where possible #164: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:39: + return -EINVAL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #164: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:39: + return -EINVAL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #165: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:40: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #168: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:42: + sfc_vdpa_log_init(sva, "name=%s, len=%zu", mz_name, len);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #171: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:44: + mz = rte_memzone_reserve_aligned(mz_name, mcdi_buff_size,$ ERROR:CODE_INDENT: code indent should use tabs where possible #178: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:50: + mz_name, (unsigned int)len,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #178: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:50: + mz_name, (unsigned int)len,$ ERROR:CODE_INDENT: code indent should use tabs where possible #179: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:51: + rte_strerror(rte_errno));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #179: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:51: + rte_strerror(rte_errno));$ total: 6 errors, 13 warnings, 33 lines checked