From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 06EB4A00C5;
Thu, 15 Sep 2022 12:24:44 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id EA6A7427F4;
Thu, 15 Sep 2022 12:24:43 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 228AB40156
for <dev@dpdk.org>; Thu, 15 Sep 2022 12:24:43 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1663237482;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=6isnk2NiTrhk48ig1NUKPaNvdX70djfSlr276f5CRNY=;
b=GsbwSah1jEByZBWJZ/rP68qUwPOUUvsbQF3eourrXPIz++swCGSR//ww/BsX4H0KhwxdR0
yVw6pVhvldSCf+6tSnT9912bO5DAKl0+eqWxeMGiy3KGsVLtdbJg/mir7ryyRjqRKUdAhO
6UaycFFcbW6YyQQH7tYiDstMdLnGgCc=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-199-FYafOWgJPe2K-OaS759SHw-1; Thu, 15 Sep 2022 06:24:38 -0400
X-MC-Unique: FYafOWgJPe2K-OaS759SHw-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
[10.11.54.4])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 53E57811E67;
Thu, 15 Sep 2022 10:24:38 +0000 (UTC)
Received: from [10.39.208.12] (unknown [10.39.208.12])
by smtp.corp.redhat.com (Postfix) with ESMTPS id E61682087440;
Thu, 15 Sep 2022 10:24:36 +0000 (UTC)
Message-ID: <68ecb973-3015-e798-893e-893a35335458@redhat.com>
Date: Thu, 15 Sep 2022 12:24:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
Thunderbird/91.12.0
Subject: Re: [PATCH v2 33/37] baseband/acc100: set device min alignment to 1
To: Hernan Vargas <hernan.vargas@intel.com>, dev@dpdk.org,
gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org
References: <20220820023157.189047-1-hernan.vargas@intel.com>
<20220820023157.189047-34-hernan.vargas@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
In-Reply-To: <20220820023157.189047-34-hernan.vargas@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 8/20/22 04:31, Hernan Vargas wrote:
> Historical mistakes, there should be no 64B alignment requirement for
> the buffer being processed. Any 1B alignment is sufficient.
>
> Fixes: 9200ffa5cd5 ("baseband/acc100: add info get function")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
> drivers/baseband/acc100/rte_acc100_pmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
> index 0e72bc1f57..461ebe67cd 100644
> --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> @@ -1201,7 +1201,7 @@ acc100_dev_info_get(struct rte_bbdev *dev,
> d->acc100_conf.q_ul_4g.num_qgroups - 1;
> dev_info->default_queue_conf = default_queue_conf;
> dev_info->cpu_flag_reqs = NULL;
> - dev_info->min_alignment = 64;
> + dev_info->min_alignment = 1;
> dev_info->capabilities = bbdev_capabilities;
> #ifdef ACC100_EXT_MEM
> dev_info->harq_buffer_size = d->ddr_size;
Move it at the beginning of the series.
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime