DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again
Date: Fri, 27 Jul 2018 09:51:21 +0100	[thread overview]
Message-ID: <68f818a6-eb93-4552-b495-ffce656338b3@intel.com> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A376E43@IRSMSX109.ger.corp.intel.com>

On 27-Jul-18 9:36 AM, Pattan, Reshma wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>> Sent: Thursday, July 26, 2018 9:05 PM
>> To: Pattan, Reshma <reshma.pattan@intel.com>
>> Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>;
>> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again
>>
>> 17/07/2018 18:00, Reshma Pattan:
>>> Previously, unit tests were running in groups. There were technical reasons
>> why that was the case (mostly having to do with limiting memory), but it was
>> hard to maintain and update the autotest script.
>>>
>>> In 18.05, limiting of memory at DPDK startup was no longer necessary, as
>> DPDK allocates memory at runtime as needed. This has the implication that
>> the old test grouping can now be retired and replaced with a more sensible
>> way of running unit tests (using multiprocessing pool of workers and a queue
>> of tests). This patchset accomplishes exactly that.
>>>
>>> This patchset merges changes done in [1], [2]
>>>
>>> [1] http://dpdk.org/dev/patchwork/patch/40370/
>>> [2] http://patches.dpdk.org/patch/40373/
>>>
>>> Removed unused and duplicate make rules for test-basic, test-mempool,
>>> test-ring from make file system in patch 10/10.
>>>
>>> v4: Removed unused and duplicate make rules for test-basic,
>>> test-mempool, test-ring from make file system in patch 10/10.
>>>
>>> Reshma Pattan (10):
>>>    autotest: fix printing
>>>    autotest: fix invalid code on reports
>>>    autotest: make autotest runner python 2/3 compliant
>>>    autotest: visually separate different test categories
>>>    autotest: improve filtering
>>>    autotest: remove autotest grouping
>>>    autotest: properly parallelize unit tests
>>>    autotest: update autotest test case list
>>>    mk: update make targets for classified testcases
>>>    mk: remove unnecessary make rules of test
>>
>> Patches 1 to 7 are from Anatoly.
>> Patches 8 and 9 were initiated by Jananee.
> 
> The respective patches have i.e 1 to 7 have Anatolys Signed--off
> And 8 and 9 have Jananees Signed-off along with mine.
> 
> I have used git-am. What I am missing here?
> 
> Thanks,
> Reshma
> 

The signoff is part of commit message, but the author name is part of 
commit metadata. I.e. as it stands, if these patches are applied, the 
commit message says i am the author, but the actual commit metadata says 
it's you.

Use "git show --pretty=fuller" to see who is the author and who is the 
committer of each commit. To fix each commit, do an interactive rebase, 
stop after each commit (i.e. mark each commit as "edit") and do

git commit --amend --author="Author Name <email@address.com>"

(this is a brute force way - a "smarter" way would be to use git 
filter-branch, but IMO it's overkill unless you do that often and 
already have all necessary scripts ready and set up :) )

-- 
Thanks,
Anatoly

  reply	other threads:[~2018-07-27  8:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 16:00 Reshma Pattan
2018-07-17 16:00 ` [dpdk-dev] [PATCH v5 01/10] autotest: fix printing Reshma Pattan
2018-07-17 16:00 ` [dpdk-dev] [PATCH v5 02/10] autotest: fix invalid code on reports Reshma Pattan
2018-07-17 16:00 ` [dpdk-dev] [PATCH v5 03/10] autotest: make autotest runner python 2/3 compliant Reshma Pattan
2018-07-17 16:00 ` [dpdk-dev] [PATCH v5 04/10] autotest: visually separate different test categories Reshma Pattan
2018-07-17 16:00 ` [dpdk-dev] [PATCH v5 05/10] autotest: improve filtering Reshma Pattan
2018-07-17 16:00 ` [dpdk-dev] [PATCH v5 06/10] autotest: remove autotest grouping Reshma Pattan
2018-07-17 16:00 ` [dpdk-dev] [PATCH v5 07/10] autotest: properly parallelize unit tests Reshma Pattan
2018-07-17 16:00 ` [dpdk-dev] [PATCH v5 08/10] autotest: update autotest test case list Reshma Pattan
2018-07-17 16:00 ` [dpdk-dev] [PATCH v5 09/10] mk: update make targets for classified testcases Reshma Pattan
2018-07-18  8:55   ` Burakov, Anatoly
2018-07-17 16:00 ` [dpdk-dev] [PATCH v5 10/10] mk: remove unnecessary make rules of test Reshma Pattan
2018-07-18  8:56   ` Burakov, Anatoly
2018-07-26 20:08   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-07-27  8:22     ` Pattan, Reshma
2018-07-27  8:45       ` Thomas Monjalon
2018-07-26 20:04 ` [dpdk-dev] [PATCH v5 00/10] Make unit tests great again Thomas Monjalon
2018-07-27  8:36   ` Pattan, Reshma
2018-07-27  8:51     ` Burakov, Anatoly [this message]
2018-07-27 10:12   ` Pattan, Reshma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68f818a6-eb93-4552-b495-ffce656338b3@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=jananeex.m.parthasarathy@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).