From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>,
"Matan Azrad" <matan@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: stat support enhancement
Date: Mon, 11 Sep 2017 17:19:53 +0100 [thread overview]
Message-ID: <68feaf54-f2a5-9801-7dbb-116eba3ccb98@intel.com> (raw)
In-Reply-To: <20170907121908.GL21444@bidouze.vm.6wind.com>
On 9/7/2017 1:19 PM, Gaëtan Rivet wrote:
> Hi Matan,
>
> You should send your v[N] In-Reply-To the Message-Id of your v[N-1]
> to help people reading.
>
> On Thu, Sep 07, 2017 at 02:31:13PM +0300, Matan Azrad wrote:
>> The previous stats code returned only the current TX sub
>> device stats.
>>
>> This enhancement extends it to return the sum of all sub
>> devices stats with history of removed sub-devices.
>>
>> Dedicated stats accumulator saves the stat history of all
>> sub device remove events.
>>
>> Each failsafe sub device contains the last stats asked by
>> the user and updates the accumulator in removal time.
>>
>> I would like to implement ultimate snapshot on removal time.
>> The stats_get API needs to be changed to return error in the
>> case it is too late to retrieve statistics.
>> By this way, failsafe can get stats snapshot in removal interrupt
>> callback for each PMD which can give stats after removal event.
>>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-09-11 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 11:31 Matan Azrad
2017-09-07 12:19 ` Gaëtan Rivet
2017-09-11 16:19 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68feaf54-f2a5-9801-7dbb-116eba3ccb98@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).