From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 88DB02B84 for ; Mon, 11 Sep 2017 18:20:00 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2017 09:19:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,378,1500966000"; d="scan'208";a="899169199" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 11 Sep 2017 09:19:53 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , Matan Azrad Cc: dev@dpdk.org References: <1504783873-4211-1-git-send-email-matan@mellanox.com> <20170907121908.GL21444@bidouze.vm.6wind.com> From: Ferruh Yigit Message-ID: <68feaf54-f2a5-9801-7dbb-116eba3ccb98@intel.com> Date: Mon, 11 Sep 2017 17:19:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170907121908.GL21444@bidouze.vm.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: stat support enhancement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 16:20:00 -0000 On 9/7/2017 1:19 PM, Gaëtan Rivet wrote: > Hi Matan, > > You should send your v[N] In-Reply-To the Message-Id of your v[N-1] > to help people reading. > > On Thu, Sep 07, 2017 at 02:31:13PM +0300, Matan Azrad wrote: >> The previous stats code returned only the current TX sub >> device stats. >> >> This enhancement extends it to return the sum of all sub >> devices stats with history of removed sub-devices. >> >> Dedicated stats accumulator saves the stat history of all >> sub device remove events. >> >> Each failsafe sub device contains the last stats asked by >> the user and updates the accumulator in removal time. >> >> I would like to implement ultimate snapshot on removal time. >> The stats_get API needs to be changed to return error in the >> case it is too late to retrieve statistics. >> By this way, failsafe can get stats snapshot in removal interrupt >> callback for each PMD which can give stats after removal event. >> >> Signed-off-by: Matan Azrad > > Acked-by: Gaetan Rivet Applied to dpdk-next-net/master, thanks.