From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20CCAA0C45; Fri, 3 Dec 2021 15:05:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F2C44067B; Fri, 3 Dec 2021 15:05:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 588DB40041 for ; Fri, 3 Dec 2021 15:05:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638540313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YyK7NgD7d/VZ4ye6lXL5BjO39edbzPqAkYOoiHw5/vY=; b=XhCzPKgd7I0D38WGh0GF9sr4nAS6wfc1BiceW3E8bMnmiGfmxiucjjykWZHF5BhCYJzb+i Rl8WPookyHxygKQhQLDnQQ+VbFn31caClb7hg2ErYPfVj0G9IWa1OtFZIAkbyww6/xHswb dXR7ETpC2VcDuBIwFdeb45R3gy4nDPE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-YgH15UEgNhOOjlep3BuECA-1; Fri, 03 Dec 2021 09:05:12 -0500 X-MC-Unique: YgH15UEgNhOOjlep3BuECA-1 Received: by mail-wr1-f71.google.com with SMTP id u4-20020a5d4684000000b0017c8c1de97dso645167wrq.16 for ; Fri, 03 Dec 2021 06:05:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=YyK7NgD7d/VZ4ye6lXL5BjO39edbzPqAkYOoiHw5/vY=; b=yMx7aBSe/NCfjeGaI8Zglic4MIwtvb6liLE5uIFNDDtg7kelWkM2i62Ef/qEYE/Hix 2YOXBq4B1xgewU85VePfdcRUj1+QIDmR5ib0fq+nncfmxsp7i4dBrye/gKef4YtQbdyz k6Okci0gLaPRHhIKG8Er3co6MmdK22XuyJziS3UF6DSvYV3QmwD2HVUidc7oezmnRC1s Rv3WIWoexTdSL9VS/SDLH0SYqaGB7Xbpn1DcMf8EXbqkFyvE2hWggqVJ2ReePnjOHNAI mwBNg+ETOzX72tFLdQhZYPEGO22tIvHofYG4elE/2BDSGVvfUctVZHAavmuBrmsdiiU+ 07gg== X-Gm-Message-State: AOAM532aUUIKXLrl2UcnQULhCq5ZHIifg7JczNX/D7mH8wXbzYCxwsdW oc4DxDEJVtxLMkcMG2KN+UFaXcMge+gmsphB4qos6wayDIQeeZSj1hk/ww86WXLLcq2QQdViLso bQKg= X-Received: by 2002:adf:f0c5:: with SMTP id x5mr20890759wro.484.1638540311460; Fri, 03 Dec 2021 06:05:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJz29I8IJRi1n/qNr5oO9R5nnnF0fUcOWm6lS5fIqNmgvSUBEDUzoxfOG8/KXzbL54b1PTP95g== X-Received: by 2002:adf:f0c5:: with SMTP id x5mr20890715wro.484.1638540311168; Fri, 03 Dec 2021 06:05:11 -0800 (PST) Received: from [192.168.0.36] ([78.18.26.230]) by smtp.gmail.com with ESMTPSA id c4sm2771342wrr.37.2021.12.03.06.05.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Dec 2021 06:05:10 -0800 (PST) Message-ID: <6909a298-7a31-e7b3-e00d-191578d39ded@redhat.com> Date: Fri, 3 Dec 2021 14:05:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: christian.ehrhardt@canonical.com, dev , Thomas Monjalon , Luca Boccassi , Xueming Li , David Marchand , Maxime Coquelin References: <20211203075415.4083502-1-christian.ehrhardt@canonical.com> <20211203075415.4083502-2-christian.ehrhardt@canonical.com> From: Kevin Traynor Subject: Re: [PATCH v2 2/2] devtools: report commit id on partial fixes In-Reply-To: <20211203075415.4083502-2-christian.ehrhardt@canonical.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 03/12/2021 07:54, christian.ehrhardt@canonical.com wrote: > From: Christian Ehrhardt > > The candidate list for backports lists partial fixes like: > "(21.02 (partially fixed in 21.08))" > That is useful to identify fixes menat for later releases, but > indirectly applying to older ones as well. > > While the devscript has no access to the stable tree to fully check > if the respective interim commit is present there, reporting the commit > id will still help to check it later - because only if the interim commit > id is in the stable tree, then also the new fix is a real candidate > for backporting. > > The above would become "(21.02 (partially fixed in c30751afc360 @ 21.08))" > > Signed-off-by: Christian Ehrhardt > --- > devtools/git-log-fixes.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh > index 27ec9088d4..a1b548948a 100755 > --- a/devtools/git-log-fixes.sh > +++ b/devtools/git-log-fixes.sh > @@ -76,7 +76,7 @@ origin_version () # ... > # look chained fix of fix recursively > local rootver="$(origin_version $roothashes)" > [ -n "$rootver" ] || continue > - echo "$rootver (partially fixed in $origver)" > + echo "$rootver (partially fixed in $origin @ $origver)" > else > echo "$origver" > fi > Acked-by: Kevin Traynor