From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2448EA046B for ; Mon, 22 Jul 2019 14:53:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E0CB61BE9B; Mon, 22 Jul 2019 14:53:43 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id D059E1BE6E for ; Mon, 22 Jul 2019 14:53:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 3D818401; Mon, 22 Jul 2019 08:53:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Jul 2019 08:53:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rbibaTbKA6FFFN2n9iWmEKuuMMxsCC1eP7K91r/QrhI=; b=jTceaI+sLVPC p2spg9cAfmIGTu1Bm4icGjdkHo8L+ycSayv8Cx6ggODpCaDtECSzJab8QGbOapA+ io6E9qTYQsroUh4LdBBby6JDlmDFEto+ws50StonTe4WprjDchE69wUI6KwOFGBn QxWxyoKp02bGYkj8O8c78Gswp6m0y8o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=rbibaTbKA6FFFN2n9iWmEKuuMMxsCC1eP7K91r/Qr hI=; b=ojeWgcuInjNH5KKb/dNtNjeXPizD1bY4ZiUuNXviuChY7j9TJh8MDVzL6 iK2Q3qvQZfa58H3rqvFERuuIxCI5GPj0cfIrLAcQJMaCIKIlllbn4q4hTxnlpmB5 ZO4RiPsAIF9+C0u58OekN53gbhVx097EJGxN/Fa9mAasYQ0/7RA6Gk2AT8ae7xE0 QAHfHVN9eD77LvGmvisYFA8R6GiAu1UqE+HMn6pdZj++bW1OZvkLOeajCxIU08dy Nk6xhbFrKg8G67KPo2TQcpvrHhfGAKXUoHszRGKW+EXnjVScU+TGuZZXNdjXko2g JkX6u7X0RCPjrV31jpAwTTOR2eS2g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrjeeggdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3A6758005A; Mon, 22 Jul 2019 08:53:38 -0400 (EDT) From: Thomas Monjalon To: "Parthasarathy, JananeeX M" Cc: dev@dpdk.org, Michael Santana Francisco , Aaron Conole , Hari Kumar Vemula , "Pattan, Reshma" , "Mcnamara, John" , "Kovacevic, Marko" , "Richardson, Bruce" , David Marchand Date: Mon, 22 Jul 2019 14:53:34 +0200 Message-ID: <6911600.pdS3C77OGP@xps> In-Reply-To: <7AE31235A30B41498D1C31348DC858BD67B6A60E@IRSMSX103.ger.corp.intel.com> References: <1549103306-9644-1-git-send-email-hari.kumarx.vemula@intel.com> <7AE31235A30B41498D1C31348DC858BD67B6A60E@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/07/2019 14:39, Parthasarathy, JananeeX M: >From: Michael Santana Francisco [mailto:msantana@redhat.com] > >On Mon, Jul 8, 2019 at 4:18 PM Aaron Conole wrote: > >> Thomas Monjalon writes: > >> >> +Building and running the unit tests > >> >> +----------------------------------- > >> >> + > >> >> +* Create the meson build output folder using the following command:: > >> >> + > >> >> + $ meson > >> >> + > >> >> +* Enter into build output folder, which was created by above command:: > >> >> + > >> >> + $ cd build > >> > > >> > Should be the same as above: > > Will change accordingly. > > >> > > >> >> + > >> >> +* Compile DPDK using command:: > >> >> + > >> >> + $ ninja > >> > > >> > Do we really need to repeat above basic steps? > >> > Would be easier to just reference another guide about meson. > >> > I think doc/build-sdk-meson.txt should be moved to .rst. > >> > >> +1 > > This doc helps to run UT, having basic steps in same page will help user to go through together and execute the same. > Just for few lines moving back and forth to different pages might be bit confusing. > Anyway still if you would prefer to remove these then only 2 sections will be available in this doc. > Please let us know if it is ok. I think it is better to avoid repetition. > >> >> +* Multiple paths:: > >> >> + > >> >> + $ CFLAGS=-I/path1 -I/path2 meson build > >> > > >> > Some quotes are missing to set multiple paths. > > Is meant here? I am just saying that space-separated value require some quotes. > >> >> +Below are some examples that show how to export libraries and > >> >> +their header paths. > >> >> + > >> >> +To specify a single library at a time:: > >> >> + > >> >> + $ export LIBRARY_PATH=/root/wireless_libs/zuc/ > >> >> + $ CFLAGS=-I/root/wireless_libs/zuc/include meson build > >> >> + > >> >> +To specify multiple libraries at a time:: > >> >> + > >> >> + $ export LIBRARY_PATH=/path/zuc/:/path/libsso_kasumi/build/ > >> >> + $ CFLAGS=-I/path/zuc/include \ > >> >> + -I/path/libsso_kasumi/include \ > >> >> + meson build > >> > > >> > Why export is used for LIBRARY_PATH and not CFLAGS? > >> > I think both variables can be exported or prepend the meson command? > > CFLAGS given in meson command works and also CFLAGS can be exported. > LIBRARY_PATH cannot be prepended to meson command. We tried but it is not reflecting the required values. > Environment variables set using export is considered and not as command line args of meson command. Please we need to understand why LIBRARY_PATH is not working when preprended in the meson command. Do you have more informations?