From: Thomas Monjalon <thomas@monjalon.net>
To: Kathleen Capella <kathleen.capella@arm.com>
Cc: dev@dpdk.org, nd@arm.com, honnappa.nagarahalli@arm.com
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix TX burst queue drain edge case
Date: Wed, 24 Mar 2021 18:15:38 +0100 [thread overview]
Message-ID: <6914149.Zb7rk1ssy2@thomas> (raw)
In-Reply-To: <20210223182300.29817-1-kathleen.capella@arm.com>
23/02/2021 19:23, Kathleen Capella:
> Initialize prev_tsc to cur_tsc. This avoids running the TX queue drain
> in the first iteration of the packet processing loop.
Is it really a fix? What was broken?
Isn't it an optimization?
> Fixes: af75078fece3 ("first public release")
If it's really a fix, we should probably backport it, so
Cc: stable@dpdk.org
> Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
next prev parent reply other threads:[~2021-03-24 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 18:23 Kathleen Capella
2021-03-24 17:15 ` Thomas Monjalon [this message]
2021-03-26 16:27 ` Kathleen Capella
2021-04-08 21:35 ` [dpdk-dev] [PATCH v2] examples/l3fwd: skip TX queue drain on first iteration Kathleen Capella
2021-04-20 1:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6914149.Zb7rk1ssy2@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=kathleen.capella@arm.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).