From: Thomas Monjalon <thomas@monjalon.net>
To: Tal Shnaiderman <talshn@mellanox.com>
Cc: dev@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com,
david.marchand@redhat.com, olivier.matz@6wind.com,
ranjit.menon@intel.com, navasile@linux.microsoft.com,
fady@mellanox.com, harini.ramakrishnan@microsoft.com,
ocardona@microsoft.com
Subject: Re: [dpdk-dev] [PATCH 2/4] eal: set byteorder in Windows to little endian
Date: Tue, 16 Jun 2020 09:50:38 +0200 [thread overview]
Message-ID: <69231367.salAEKAJ0m@thomas> (raw)
In-Reply-To: <20200601093818.5420-3-talshn@mellanox.com>
01/06/2020 11:38, talshn@mellanox.com:
> From: Tal Shnaiderman <talshn@mellanox.com>
>
> Set the endianness in Windows to RTE_LITTLE_ENDIAN as support
> for Windows is limited to x86 architecture for now.
>
> Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
> ---
> --- a/lib/librte_eal/include/generic/rte_byteorder.h
> +++ b/lib/librte_eal/include/generic/rte_byteorder.h
> #ifdef RTE_EXEC_ENV_FREEBSD
> #include <sys/endian.h>
> -#else
> +#elif defined RTE_EXEC_ENV_LINUX
> #include <endian.h>
> +#elif defined RTE_EXEC_ENV_WINDOWS && !defined RTE_BYTE_ORDER
Why "&& !defined RTE_BYTE_ORDER" ?
How can it be defined earlier?
> +#define RTE_BYTE_ORDER RTE_LITTLE_ENDIAN
> #endif
next prev parent reply other threads:[~2020-06-16 7:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 9:38 [dpdk-dev] [PATCH 0/4] Support librte_mbuf on Windows talshn
2020-06-01 9:38 ` [dpdk-dev] [PATCH 1/4] eal: move OS common config code to single file talshn
2020-06-25 15:24 ` [dpdk-dev] [PATCH v2 0/3] Support librte_mbuf on Windows talshn
2020-06-25 15:24 ` [dpdk-dev] [PATCH v2 1/3] eal: correct OS headers in rte_byteorder.h talshn
2020-06-25 15:24 ` [dpdk-dev] [PATCH v2 2/3] eal: export needed functions for mbuf talshn
2020-06-25 15:24 ` [dpdk-dev] [PATCH v2 3/3] mbuf: build on Windows talshn
2020-07-07 0:01 ` [dpdk-dev] [PATCH v2 0/3] Support librte_mbuf " Thomas Monjalon
2020-06-01 9:38 ` [dpdk-dev] [PATCH 2/4] eal: set byteorder in Windows to little endian talshn
2020-06-16 7:50 ` Thomas Monjalon [this message]
2020-06-25 13:24 ` Tal Shnaiderman
2020-06-01 9:38 ` [dpdk-dev] [PATCH 3/4] eal: export needed functions for mbuf talshn
2020-06-16 8:09 ` Thomas Monjalon
2020-06-16 8:33 ` Tal Shnaiderman
2020-06-16 8:45 ` Thomas Monjalon
2020-06-16 9:26 ` Dmitry Kozlyuk
2020-06-16 11:44 ` Thomas Monjalon
2020-06-01 9:38 ` [dpdk-dev] [PATCH 4/4] mbuf: build on Windows talshn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69231367.salAEKAJ0m@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).