Re: [dpdk-dev] [RFC] remove unused functions

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 11/24/2020 10:00 AM, Zhang, Tianfei wrote:
> 
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: 2020年11月23日 17:57
>> To: Zhang, Tianfei <tianfei.zhang@intel.com>; Jerin Jacob
>> <jerinj@marvell.com>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>;
>> Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena
>> <sachin.saxena@oss.nxp.com>; Ray Kinsella <mdr@ashroe.eu>; Neil Horman
>> <nhorman@tuxdriver.com>; Xu, Rosen <rosen.xu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Nithin
>> Dabilpuram <ndabilpuram@marvell.com>; Ajit Khaparde
>> <ajit.khaparde@broadcom.com>; Raveendra Padasalagi
>> <raveendra.padasalagi@broadcom.com>; Vikas Gupta
>> <vikas.gupta@broadcom.com>; Gagandeep Singh <g.singh@nxp.com>;
>> Somalapuram Amaranath <asomalap@amd.com>; Akhil Goyal
>> <akhil.goyal@nxp.com>; Jay Zhou <jianjay.zhou@huawei.com>; McDaniel,
>> Timothy <timothy.mcdaniel@intel.com>; Ma, Liang J <liang.j.ma@intel.com>;
>> Mccarthy, Peter <peter.mccarthy@intel.com>; Shepard Siegel
>> <shepard.siegel@atomicrules.com>; Ed Czeck <ed.czeck@atomicrules.com>;
>> John Miller <john.miller@atomicrules.com>; Igor Russkikh
>> <igor.russkikh@aquantia.com>; Pavel Belous <pavel.belous@aquantia.com>;
>> Rasesh Mody <rmody@marvell.com>; Shahed Shaikh
>> <shshaikh@marvell.com>; Somnath Kotur <somnath.kotur@broadcom.com>;
>> Chas Williams <chas3@att.com>; Min Hu (Connor) <humin29@huawei.com>;
>> Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>; Guo, Jia
>> <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Marcin
>> Wojtas <mw@semihalf.com>; Michal Krawczyk <mk@semihalf.com>; Guy
>> Tzalik <gtzalik@amazon.com>; Evgeny Schemeilin <evgenys@amazon.com>;
>> Igor Chauskin <igorch@amazon.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
>> Wang, Xiao W <xiao.w.wang@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>; Alfredo Cardigliano <cardigliano@ntop.org>;
>> Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>;
>> Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Zyta Szpak
>> <zr@semihalf.com>; Liron Himi <lironh@marvell.com>; Stephen Hemminger
>> <sthemmin@microsoft.com>; K. Y. Srinivasan <kys@microsoft.com>; Haiyang
>> Zhang <haiyangz@microsoft.com>; Long Li <longli@microsoft.com>; Heinrich
>> Kuhn <heinrich.kuhn@netronome.com>; Harman Kalra
>> <hkalra@marvell.com>; Kiran Kumar K <kirankumark@marvell.com>; Andrew
>> Rybchenko <andrew.rybchenko@oktetlabs.ru>; Singh, Jasvinder
>> <jasvinder.singh@intel.com>; Jiawen Wu <jiawenwu@trustnetic.com>; Jian
>> Wang <jianwang@trustnetic.com>; Ori Kam <orika@nvidia.com>; Guy Kaneti
>> <guyk@marvell.com>; Burakov, Anatoly <anatoly.burakov@intel.com>;
>> Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
>> <chenbo.xia@intel.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [RFC] remove unused functions
>>
>> On 11/23/2020 2:55 AM, Zhang, Tianfei wrote:
>>>>    drivers/raw/ifpga/base/opae_eth_group.c       |   25 -
>>>>    drivers/raw/ifpga/base/opae_eth_group.h       |    1 -
>>>>    drivers/raw/ifpga/base/opae_hw_api.c          |  212 --
>>>>    drivers/raw/ifpga/base/opae_hw_api.h          |   36 -
>>>>    drivers/raw/ifpga/base/opae_i2c.c             |   12 -
>>>>    drivers/raw/ifpga/base/opae_i2c.h             |    4 -
>>>>    drivers/raw/ifpga/base/opae_ifpga_hw_api.c    |   99 -
>>>>    drivers/raw/ifpga/base/opae_ifpga_hw_api.h    |   15 -
>>>
>>> The ifpga base code is want to provide fully functionality low level hardware
>> support for Intel FPGA card like N3000, even though some APIs are not used
>> by DPDK framework now，but it will useful for end-users or other customers
>> developing their own productions , my opinion is keeping those APIs of ifpga
>> base code in DPDK.
>>>
>>
>> The code is hidden behind the driver code, it is not accessible to user directly.
>>
>> If the idea is the code can be used later, it can be added when needed.
> 
> Sound good!
>>
>> If the idea is the code can be needed in the field by users, can you please give
>> example on the use case?
> 
> Do you mean write some test cases in examples folder?
> 

You mentioned end user may need some of the removed functions, can you give an 
example how an end user may need them?