From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1787AA04B1; Tue, 24 Nov 2020 11:26:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5D85C90E; Tue, 24 Nov 2020 11:26:22 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B0176C904 for ; Tue, 24 Nov 2020 11:26:20 +0100 (CET) IronPort-SDR: Al5pvkZKYL8dupO2otlaedzMWhQEWCQqc52HC4TEQoF0PTDd4nXDaWn7HWCkl5VlRsnq4G1Np5 /TrHguJ3RFDg== X-IronPort-AV: E=McAfee;i="6000,8403,9814"; a="168413572" X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="168413572" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 02:26:18 -0800 IronPort-SDR: DH16vpJ53yvlDB3DtqVuaG0mSkWGEAqGrFEePDzW/XsVAZjFrZn4xsryflG0J5bqK5zXmvoTcO u0HcCJWc+vWQ== X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="370328591" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.85.132]) ([10.251.85.132]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 02:26:06 -0800 To: "Zhang, Tianfei" , Jerin Jacob , "Dumitrescu, Cristian" , Hemant Agrawal , Sachin Saxena , Ray Kinsella , Neil Horman , "Xu, Rosen" , "Wu, Jingjing" , "Xing, Beilei" , Nithin Dabilpuram , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Gagandeep Singh , Somalapuram Amaranath , Akhil Goyal , Jay Zhou , "McDaniel, Timothy" , "Ma, Liang J" , "Mccarthy, Peter" , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Rasesh Mody , Shahed Shaikh , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Rahul Lakkireddy , "Guo, Jia" , "Wang, Haiyue" , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , "Zhang, Qi Z" , "Wang, Xiao W" , "Yang, Qiming" , Alfredo Cardigliano , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Heinrich Kuhn , Harman Kalra , Kiran Kumar K , Andrew Rybchenko , "Singh, Jasvinder" , Jiawen Wu , Jian Wang , Ori Kam , Guy Kaneti , "Burakov, Anatoly" , Maxime Coquelin , "Xia, Chenbo" Cc: "dev@dpdk.org" References: <20201119035238.3653702-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <692cbe0f-618e-ad65-427a-0309c49bc424@intel.com> Date: Tue, 24 Nov 2020 10:26:02 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC] remove unused functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/24/2020 10:00 AM, Zhang, Tianfei wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: 2020年11月23日 17:57 >> To: Zhang, Tianfei ; Jerin Jacob >> ; Dumitrescu, Cristian ; >> Hemant Agrawal ; Sachin Saxena >> ; Ray Kinsella ; Neil Horman >> ; Xu, Rosen ; Wu, Jingjing >> ; Xing, Beilei ; Nithin >> Dabilpuram ; Ajit Khaparde >> ; Raveendra Padasalagi >> ; Vikas Gupta >> ; Gagandeep Singh ; >> Somalapuram Amaranath ; Akhil Goyal >> ; Jay Zhou ; McDaniel, >> Timothy ; Ma, Liang J ; >> Mccarthy, Peter ; Shepard Siegel >> ; Ed Czeck ; >> John Miller ; Igor Russkikh >> ; Pavel Belous ; >> Rasesh Mody ; Shahed Shaikh >> ; Somnath Kotur ; >> Chas Williams ; Min Hu (Connor) ; >> Rahul Lakkireddy ; Guo, Jia >> ; Wang, Haiyue ; Marcin >> Wojtas ; Michal Krawczyk ; Guy >> Tzalik ; Evgeny Schemeilin ; >> Igor Chauskin ; Zhang, Qi Z ; >> Wang, Xiao W ; Yang, Qiming >> ; Alfredo Cardigliano ; >> Matan Azrad ; Shahaf Shuler ; >> Viacheslav Ovsiienko ; Zyta Szpak >> ; Liron Himi ; Stephen Hemminger >> ; K. Y. Srinivasan ; Haiyang >> Zhang ; Long Li ; Heinrich >> Kuhn ; Harman Kalra >> ; Kiran Kumar K ; Andrew >> Rybchenko ; Singh, Jasvinder >> ; Jiawen Wu ; Jian >> Wang ; Ori Kam ; Guy Kaneti >> ; Burakov, Anatoly ; >> Maxime Coquelin ; Xia, Chenbo >> >> Cc: dev@dpdk.org >> Subject: Re: [RFC] remove unused functions >> >> On 11/23/2020 2:55 AM, Zhang, Tianfei wrote: >>>> drivers/raw/ifpga/base/opae_eth_group.c | 25 - >>>> drivers/raw/ifpga/base/opae_eth_group.h | 1 - >>>> drivers/raw/ifpga/base/opae_hw_api.c | 212 -- >>>> drivers/raw/ifpga/base/opae_hw_api.h | 36 - >>>> drivers/raw/ifpga/base/opae_i2c.c | 12 - >>>> drivers/raw/ifpga/base/opae_i2c.h | 4 - >>>> drivers/raw/ifpga/base/opae_ifpga_hw_api.c | 99 - >>>> drivers/raw/ifpga/base/opae_ifpga_hw_api.h | 15 - >>> >>> The ifpga base code is want to provide fully functionality low level hardware >> support for Intel FPGA card like N3000, even though some APIs are not used >> by DPDK framework now，but it will useful for end-users or other customers >> developing their own productions , my opinion is keeping those APIs of ifpga >> base code in DPDK. >>> >> >> The code is hidden behind the driver code, it is not accessible to user directly. >> >> If the idea is the code can be used later, it can be added when needed. > > Sound good! >> >> If the idea is the code can be needed in the field by users, can you please give >> example on the use case? > > Do you mean write some test cases in examples folder? > You mentioned end user may need some of the removed functions, can you give an example how an end user may need them?