From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 84833A04DD;
	Mon, 16 Nov 2020 21:35:55 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5EC342C16;
	Mon, 16 Nov 2020 21:35:54 +0100 (CET)
Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com
 [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 83382F94
 for <dev@dpdk.org>; Mon, 16 Nov 2020 21:35:52 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailnew.nyi.internal (Postfix) with ESMTP id 1F93B58015D;
 Mon, 16 Nov 2020 15:35:51 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Mon, 16 Nov 2020 15:35:51 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 LVF+LiXWqiwkfwzLX3bcr1UnV3j8OalF5Z4aDZ2bh0I=; b=VYfTzFqf4Y3PDo1l
 J3SZHjnKLAD/2LKxDSKxWrOQ/wmxMYMCWGxyLDhwdJ/EuF0eas5Cz14V9YHF2UgR
 oWeTY77AHvqxpo0XqrIf6rJOYSJgiscdfCwGpaOA3AcFG7UL8UIblUCnCQSfNLie
 Qz+OLWdDqVtFJYQMhVw89ywzYg+t/jJRWV9mOnlN24BXQAGT8bl7PohMc5+cOcZn
 8gDKlMN0vbkHb83ep4klXG03u3nstogaTySx9VcaTo4UKiaHNGFvwHeXbWDBpNlV
 qb9HTqo8EfT+UEe4liV6BvsVyM71oZ+t6px1leSU8PKxXLkAEH6Ao3sPJ5TgBA/P
 r8JTLw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=LVF+LiXWqiwkfwzLX3bcr1UnV3j8OalF5Z4aDZ2bh
 0I=; b=bu7iD8QnpSqpbQ+v1BqmS6Hxs95NkMdbyL8aGnIAdexUrReQovK58v5R9
 +v77m+hYzdUY6R6OZWpOa8r+yhyalOTBDwd0lf7H+WdfDT9Eb/ggCaotb5/CRxKK
 +aZXFB83uOHVwgCZf23GJ0V95LrYjm6jDCCnZnJm5D1Qe6ZB1jV0gsztJ8pEVjgr
 nYcybxppa+RI1o96KeRdGmLHFLDU6LXzgBBuxevdVxXpR6qwJR4f8b11ggqSJn9a
 GMNY6PkPxOU332eN23kPMwuJAvpnL5NXKd/718oGuKA0jmZDsiDYvOHd/6YU/Kwt
 lcLWVWl0DNOEAK4auDsiAQoR5FvGA==
X-ME-Sender: <xms:puKyX8ctpq_PdtsmeEUSpha4xy2MNAzB3UqypHcnuQAsBNZxkBFkpA>
 <xme:puKyX-NjTCTmXK1MTCuatLpXPEWYRCX-fEf_Haky1lxcSNxAxrZQupai-uf67c8Nl
 mvHmvoNnl89lLprHw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefuddgudeflecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm
 rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
 ggtffrrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdev
 uedtjeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh
 fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr
 lhhonhdrnhgvth
X-ME-Proxy: <xmx:puKyX9jR6PzQVsao3nSngtNYgEQmr5_I1Nj6AwUn9xdR-llRwXCK8A>
 <xmx:puKyXx_VrOOe43ZN1p5pja6etr0DL2u8g-fa596Tg6SdCDsk8z6KmQ>
 <xmx:puKyX4tc6M4GeF9YwFezuHqxR3G_oLd1fC_KEWYIBYPJdoTjmUU-xw>
 <xmx:p-KyX6J7rXeni84aHazJqew8AmcEK4wKkdF9-fHT0xy6vQ69I9BKcg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id C26153064AAE;
 Mon, 16 Nov 2020 15:35:49 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Juraj =?utf-8?B?TGlua2XFoQ==?= <juraj.linkes@pantheon.tech>
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "Ruifeng.Wang@arm.com" <Ruifeng.Wang@arm.com>,
 "Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
 "Phil.Yang@arm.com" <Phil.Yang@arm.com>,
 "vcchunga@amazon.com" <vcchunga@amazon.com>,
 "Dharmik.Thakkar@arm.com" <Dharmik.Thakkar@arm.com>,
 "jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
 "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
 "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Date: Mon, 16 Nov 2020 21:35:48 +0100
Message-ID: <6931484.7dh0Ehd6GZ@thomas>
In-Reply-To: <2242bb813ffa4002b53909fcba01de89@pantheon.tech>
References: <1605267483-13167-1-git-send-email-juraj.linkes@pantheon.tech>
 <5863230.hsDCxHRDzd@thomas> <2242bb813ffa4002b53909fcba01de89@pantheon.tech>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v12 11/14] build: disable Arm drivers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

16/11/2020 16:54, Juraj Linke=C5=A1:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 16/11/2020 08:56, Juraj Linke=C5=A1:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > >
> > > > What do you mean by "disable Arm drivers"?
> > > > What are "Arm drivers"
> > > >
> > >
> > > These are the drivers that we're disableing for Arm builds. I'll chan=
ge it to
> > something more clearer like "disable drivers in Arm builds"
> > >
> > > > 13/11/2020 15:31, Juraj Linke=C5=A1:
> > > > > A few options that disabled drivers in the old makefiles were
> > > > > improperly ported to the meson build system. Fix this by adding a
> > > > > to the list of disabled drivers, similarly how the command line
> > > > > option works. Remove unneeded driver options ported from the old
> > makefile system.
> > > > > Add support for removing drivers for cross builds.
> > > > >
> > > > > Signed-off-by: Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech>
> > > > > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > > > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > > > [...]
> > > > > -	['RTE_NET_FM10K', false],
> > > > > -	['RTE_NET_AVP', false],
> > > >
> > > > Isn't it enabling drivers?
> > > >
> > >
> > > These options don't do anything in the way the current meson build sy=
stem is
> > set up, since they'll be overwritten in drivers/meson.build. The order =
is, from
> > meson.build (in the git root):
> > > subdir('config')   # here we're setting arm specific flags
> > > ...
> > > subdir('drivers')  # and here they'd be overwritten
> >=20
> > Should this change be in the same patch as disabling some drivers?
> > If yes, please explain in the commit log.
> >=20
>=20
> I think so, the fix consist not only of adding support for disabling driv=
ers, but also removing the parts that look like they're doing that but fail=
 to do so (so, in essence replacing the faulty config with proper support).=
 I'll update the commit message.

OK