* [dpdk-dev] [PATCH v2] net/i40e: improve i40evf buffer cleanup in Tx vector mode
@ 2017-10-06 14:08 Roger B Melton
2017-10-10 17:40 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Roger B Melton @ 2017-10-06 14:08 UTC (permalink / raw)
To: jingjing.wu; +Cc: dev, Roger B Melton
Signed-off-by: Roger B Melton <rmelton@cisco.com>
---
v2 - Same content as v1, but properly signed-off.
i40evf tx vector logic frees mbufs, but it does not remove the
mbufs from software rings which leads to double frees. This change
corrects that oversight. I've validated this fix within our application.
drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h
index 39a6da0..fdc6fce 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
@@ -127,6 +127,7 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
if (likely(m != NULL)) {
free[0] = m;
nb_free = 1;
+ txep[0].mbuf = NULL;
for (i = 1; i < n; i++) {
m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
if (likely(m != NULL)) {
@@ -139,14 +140,17 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
free[0] = m;
nb_free = 1;
}
+ txep[i].mbuf = NULL;
}
}
rte_mempool_put_bulk(free[0]->pool, (void **)free, nb_free);
} else {
+ txep[0].mbuf = NULL;
for (i = 1; i < n; i++) {
m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
if (m != NULL)
rte_mempool_put(m->pool, m);
+ txep[i].mbuf = NULL;
}
}
--
2.10.3.dirty
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/i40e: improve i40evf buffer cleanup in Tx vector mode
2017-10-06 14:08 [dpdk-dev] [PATCH v2] net/i40e: improve i40evf buffer cleanup in Tx vector mode Roger B Melton
@ 2017-10-10 17:40 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-10-10 17:40 UTC (permalink / raw)
To: Roger B Melton, jingjing.wu; +Cc: dev
On 10/6/2017 3:08 PM, Roger B Melton wrote:
> Signed-off-by: Roger B Melton <rmelton@cisco.com>
> ---
> v2 - Same content as v1, but properly signed-off.
This patch marked as Superseded in patchwork by patch:
http://dpdk.org/dev/patchwork/patch/30023/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-10 17:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-06 14:08 [dpdk-dev] [PATCH v2] net/i40e: improve i40evf buffer cleanup in Tx vector mode Roger B Melton
2017-10-10 17:40 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).