Re: [dpdk-dev] [PATCH v3] net/i40e: fix multiple DDP packages should not be allowed

["Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>]

Hi Beilei,

> -----Original Message-----
> From: Xing, Beilei
> Sent: Monday 5 February 2018 10:41
> To: Rybalchenko, Kirill <kirill.rybalchenko@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Chilikin, Andrey <andrey.chilikin@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>
> Subject: RE: [PATCH v3] net/i40e: fix multiple DDP packages should not be
> allowed
> 
> > @@ -1628,12 +1655,17 @@ rte_pmd_i40e_process_ddp_package(uint16_t
> > port, uint8_t *buff,
> >
> >  	if (op == RTE_PMD_I40E_PKG_OP_WR_ADD) {
> >  		if (is_exist) {
> 
> How about removing the above if statement since there're 3 if statements
> for is_exist below?


This if statement is necessary because these two lines
			rte_free(profile_info_sec);
  			return -EEXIST;
should be executed only if is_exist has non-zero value.
Statements
			if (is_exist == 1, 2, 3)
are only selector for appropriate log message.

Or did I misunderstand your idea? 

> 
> > -			PMD_DRV_LOG(ERR, "Profile already exists.");
> > +			if (is_exist == 1)
> > +				PMD_DRV_LOG(ERR, "Profile already
> > exists.");
> > +			else if (is_exist == 2)
> > +				PMD_DRV_LOG(ERR, "Profile of group 0
> > already exists.");
> > +			else if (is_exist == 3)
> > +				PMD_DRV_LOG(ERR, "Profile of different
> > group already exists");
> >  			rte_free(profile_info_sec);
> >  			return -EEXIST;
> >  		}
> >  	} else if (op == RTE_PMD_I40E_PKG_OP_WR_DEL) {
> > -		if (!is_exist) {
> > +		if (is_exist != 1) {
> >  			PMD_DRV_LOG(ERR, "Profile does not exist.");
> >  			rte_free(profile_info_sec);
> >  			return -EACCES;
> > --
> > 2.5.5

Regards,
Kirill.