From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id BFE99A48C for ; Wed, 14 Mar 2018 12:59:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 04:59:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,470,1515484800"; d="scan'208";a="208126453" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga005.jf.intel.com with ESMTP; 14 Mar 2018 04:59:45 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 14 Mar 2018 11:59:44 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.9]) by irsmsx112.ger.corp.intel.com ([169.254.1.242]) with mapi id 14.03.0319.002; Wed, 14 Mar 2018 11:59:44 +0000 From: "Rybalchenko, Kirill" To: "Wu, Yanglong" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Lu, Wenzhuo" , "Wu, Yanglong" Thread-Topic: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error Thread-Index: AQHTmwJRC+aAVlt8hk2Ojx2RhecPvqPP4Tjg Date: Wed, 14 Mar 2018 11:59:43 +0000 Message-ID: <696B43C21188DF4F9C9091AAE4789B824E2D633D@IRSMSX108.ger.corp.intel.com> References: <20180201021128.174110-1-yanglong.wu@intel.com> In-Reply-To: <20180201021128.174110-1-yanglong.wu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzAxNmNkOTItZWM3OS00NjY4LWI4OGMtYjFhZjE0MjdjMDE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik12VzNZNWhjQmlaTXpXV1dDaGNqbjQ2ZDNXUklpU3E5UjNoblI5T3M5NUk9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 11:59:48 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > Sent: Thursday 1 February 2018 02:11 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Lu, Wenzhuo > ; Wu, Yanglong > Subject: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error >=20 > In VF, the number of ibytes read from register have been stripped out CRC > already, but in stats, it subtracts CRC bytes again. So it lead to RX byt= es is > smaller than TX bytes. >=20 > Fixes: 98abce23(fix VF statistics) > Signed-off-by: Yanglong Wu > --- > drivers/net/i40e/i40e_ethdev.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index c4df65df0..84e82889a 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -2440,10 +2440,6 @@ i40e_update_vsi_stats(struct i40e_vsi *vsi) > i40e_stat_update_48(hw, I40E_GLV_BPRCH(idx), > I40E_GLV_BPRCL(idx), > vsi->offset_loaded, &oes->rx_broadcast, > &nes->rx_broadcast); > - /* exclude CRC bytes */ > - nes->rx_bytes -=3D (nes->rx_unicast + nes->rx_multicast + > - nes->rx_broadcast) * ETHER_CRC_LEN; > - > i40e_stat_update_32(hw, I40E_GLV_RDPC(idx), vsi->offset_loaded, > &oes->rx_discards, &nes->rx_discards); > /* GLV_REPC not supported */ > -- > 2.11.0 Reviewed-by: Kirill Rybalchenko