From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 550364C8F for ; Wed, 14 Mar 2018 16:16:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 08:16:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,470,1515484800"; d="scan'208";a="211261575" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga006.fm.intel.com with ESMTP; 14 Mar 2018 08:16:31 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.9]) by IRSMSX102.ger.corp.intel.com ([169.254.2.10]) with mapi id 14.03.0319.002; Wed, 14 Mar 2018 15:16:30 +0000 From: "Rybalchenko, Kirill" To: "Xing, Beilei" , "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration Thread-Index: AQHTowc61RJVD0WwFk+FnFYTZyxryaPQCLZQ Date: Wed, 14 Mar 2018 15:16:30 +0000 Message-ID: <696B43C21188DF4F9C9091AAE4789B824E2D65CC@IRSMSX108.ger.corp.intel.com> References: <1518332974-86392-1-git-send-email-beilei.xing@intel.com> In-Reply-To: <1518332974-86392-1-git-send-email-beilei.xing@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWViNzg4NTQtZGVkNC00ZmUzLTg1N2UtM2MxNjQ1MDQ5YzI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InBGOExibDVMcmFFbURtUWlWdlVCYjNpbzNoOUZsQXlZXC9IVEFxNVlKczM0PSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 15:16:37 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing > Sent: Sunday 11 February 2018 07:10 > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask > configuration >=20 > Remove unnecessary FDIR mask configuration, otherwise flow directory > mask will be changed when configuring hash input set. >=20 > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/rte_pmd_i40e.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/drivers/net/i40e/rte_pmd_i40e.c > b/drivers/net/i40e/rte_pmd_i40e.c index 1288c51..b684249 100644 > --- a/drivers/net/i40e/rte_pmd_i40e.c > +++ b/drivers/net/i40e/rte_pmd_i40e.c > @@ -3094,10 +3094,6 @@ rte_pmd_i40e_inset_set(uint16_t port, uint8_t > pctype, > return -ENOTSUP; > } >=20 > - /* Clear mask first */ > - for (i =3D 0; i < 2; i++) > - i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype), > 0); > - > inset_reg =3D inset->inset; > for (i =3D 0; i < 2; i++) > mask_reg[i] =3D (inset->mask[i].field_idx << 16) | > -- > 2.5.5 Reviewed-by: Kirill Rybalchenko