From: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"dev@dpdk.org" <dev@dpdk.org>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: remove old deprecation notice
Date: Fri, 25 May 2018 14:47:00 +0000 [thread overview]
Message-ID: <696B43C21188DF4F9C9091AAE4789B824E31064C@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1669017.uGNrKsOYHy@xps>
Hi Tomas,
> You CC:stable because it was implemented in 18.02
Sorry, I was misled by check-git-log script warning.
> > Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS")
>
> The Fixes line should not reference the initial announce, but the commit
> implementing it, because the deprecation notice should have been removed
> while implementing the new API.
The actual fixline should be:
Fixes: d2f9fe8ae309 ("net/i40e: turn off flexible payload on driver init")
Shall I make v2 of this patch or you can apply it with those little fixes?
Thanks,
Kirill.
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday 25 May 2018 11:51
> To: Rybalchenko, Kirill <kirill.rybalchenko@intel.com>
> Cc: stable@dpdk.org; dev@dpdk.org; nhorman@tuxdriver.com; Mcnamara,
> John <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-stable] [PATCH] doc: remove old deprecation notice
>
> 25/05/2018 11:17, Kirill Rybalchenko:
> > New default configuration without flexible payload is implemented now.
> >
> > Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS")
>
> The Fixes line should not reference the initial announce, but the commit
> implementing it, because the deprecation notice should have been removed
> while implementing the new API.
>
> > Cc: stable@dpdk.org
>
> You CC:stable because it was implemented in 18.02?
>
>
next prev parent reply other threads:[~2018-05-25 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 9:17 [dpdk-dev] " Kirill Rybalchenko
2018-05-25 10:51 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-05-25 14:47 ` Rybalchenko, Kirill [this message]
2018-05-25 14:56 ` Thomas Monjalon
2018-05-27 23:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=696B43C21188DF4F9C9091AAE4789B824E31064C@IRSMSX108.ger.corp.intel.com \
--to=kirill.rybalchenko@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).