DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
	"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove not needed query if and rd from create qp
Date: Thu, 30 Mar 2017 17:03:49 +0000	[thread overview]
Message-ID: <69708566-2900-4781-B12A-AFFC7C7B2896@mellanox.com> (raw)
In-Reply-To: <20170330080645.30973-1-shahafs@mellanox.com>


Hi,

> On Mar 30, 2017, at 1:06 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
> 
> Since mlx5 PMD data path is on top of PRM, such verbs calls are
> no longer needed.
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Acked-by: Yongseok Koh <yskoh@mellanox.com>

I ack the code change but one small suggestion regarding the commit header.
It looks like 'if' means interface, 'rd' means the Resource Domain, and
'qp' means the Queue Pair. which are all mellanox specific terms and
acronyms. My suggestion is:

net/mlx5: remove unnecessary Verbs library calls

And how about moving the details into the message body:

Remove unnecessary interface queries and the Resource Domain when creating
the Queue Pair. Since mlx5 PMD data path is on top of native APIs, such
Verbs library calls are no longer needed.

Thanks,
Yongseok

  reply	other threads:[~2017-03-30 17:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30  8:06 Shahaf Shuler
2017-03-30 17:03 ` Yongseok Koh [this message]
2017-03-30 17:08   ` Ferruh Yigit
2017-03-31  9:23   ` Ferruh Yigit
2017-04-02 11:29 ` [dpdk-dev] [PATCH v2] net/mlx5: remove unnecessary Verbs library calls Shahaf Shuler
2017-04-03 10:20   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69708566-2900-4781-B12A-AFFC7C7B2896@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=shahafs@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).