From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0070.outbound.protection.outlook.com [104.47.2.70]) by dpdk.org (Postfix) with ESMTP id 6375F37B2 for ; Thu, 30 Mar 2017 19:03:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PrbmAgUBuJoF5n170OwmjhP8PT9o4l+zFBz7/dCexoE=; b=Ftf04LbcurtK8uwVoAVCQsdw9tz5HRBcrkFXdqMfCVgo2PJv5TzzwP25j2G48d7VdIwxedYLeO7KSkDu3Uma6Zo2D6FkRqGVM3oI1PuShqDF0BktKsZeUCucr7JH3Vxr0pL2s/nCW9Lm3+86ZAsjDUhFdvdUbZFIGZTxipnR0eU= Received: from DB6PR0501MB2455.eurprd05.prod.outlook.com (10.168.73.136) by DB5PR05MB1510.eurprd05.prod.outlook.com (10.164.39.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14; Thu, 30 Mar 2017 17:03:49 +0000 Received: from DB6PR0501MB2455.eurprd05.prod.outlook.com ([10.168.73.136]) by DB6PR0501MB2455.eurprd05.prod.outlook.com ([10.168.73.136]) with mapi id 15.01.0991.022; Thu, 30 Mar 2017 17:03:49 +0000 From: Yongseok Koh To: Shahaf Shuler CC: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Adrien Mazarguil" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: remove not needed query if and rd from create qp Thread-Index: AQHSqXeZwZeZSAuYpE+ftqt2dDia2g== Date: Thu, 30 Mar 2017 17:03:49 +0000 Message-ID: <69708566-2900-4781-B12A-AFFC7C7B2896@mellanox.com> References: <20170330080645.30973-1-shahafs@mellanox.com> In-Reply-To: <20170330080645.30973-1-shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [12.250.235.110] x-microsoft-exchange-diagnostics: 1; DB5PR05MB1510; 7:4KNfFrifsptrMuj1rUnR6E1WzDxPw7KwacpetOyrLj1VctrNHqnTT0JqgGi6BChmGuk1heNjLCgAft6BEIoAC7kIFKlj3ljkOFIIexieOBHKrEwLGH+lAtDcIMj93aAw5lJcimGGegcDKlATXFA479plvjcQDmdoDtQQRbf1ccMMZXdN9Tx4rxV/6rS/MNB8RBGvHuLfQabrVdHKJoAZIFymvZo/q5mU2j4sI6i9xJH1L7xL2FqgEGxX8SOTQGcaE1H5g2xNtLzK/wg4dSnVSJWZuMdtSyW0POLfHBJ04j8OEp7b7fqUxoIANpgWxGTfM1yocbl6SlG8bIcPon1MIA== x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: bab26604-d255-427c-b3ca-08d4778ebc71 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:DB5PR05MB1510; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123562025)(20161123560025)(6072148); SRVR:DB5PR05MB1510; BCL:0; PCL:0; RULEID:; SRVR:DB5PR05MB1510; x-forefront-prvs: 02622CEF0A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39450400003)(39860400002)(39850400002)(39400400002)(39410400002)(39840400002)(377454003)(24454002)(99286003)(6512007)(229853002)(54906002)(6506006)(6486002)(77096006)(8936002)(6436002)(36756003)(8676002)(81166006)(83716003)(2900100001)(7736002)(6116002)(86362001)(102836003)(3846002)(4326008)(6246003)(38730400002)(110136004)(6862004)(2906002)(82746002)(5660300001)(305945005)(25786009)(2950100002)(3280700002)(6636002)(66066001)(189998001)(50986999)(53936002)(33656002)(54356999)(76176999)(122556002)(3660700001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR05MB1510; H:DB6PR0501MB2455.eurprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2017 17:03:49.3959 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1510 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove not needed query if and rd from create qp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 17:03:50 -0000 Hi, > On Mar 30, 2017, at 1:06 AM, Shahaf Shuler wrote: >=20 > Since mlx5 PMD data path is on top of PRM, such verbs calls are > no longer needed. >=20 > Signed-off-by: Shahaf Shuler > Acked-by: Nelio Laranjeiro Acked-by: Yongseok Koh I ack the code change but one small suggestion regarding the commit header. It looks like 'if' means interface, 'rd' means the Resource Domain, and 'qp' means the Queue Pair. which are all mellanox specific terms and acronyms. My suggestion is: net/mlx5: remove unnecessary Verbs library calls And how about moving the details into the message body: Remove unnecessary interface queries and the Resource Domain when creating the Queue Pair. Since mlx5 PMD data path is on top of native APIs, such Verbs library calls are no longer needed. Thanks, Yongseok