From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BAB3A04B5; Fri, 6 Nov 2020 18:30:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DED83100C; Fri, 6 Nov 2020 18:30:18 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A7B59160 for ; Fri, 6 Nov 2020 18:30:16 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 5681B5C018A; Fri, 6 Nov 2020 12:30:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 06 Nov 2020 12:30:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= eLUiqZik8J60s5XUBVbGRXtjCxh7z7KsWeVPgokgyiI=; b=eZYJ695dLe1oI4hd sjEIQz0gsUAL3OTeW1FaRDt7k1v+ZSAwQ0QcJ2+JMp87JY+EuPzJ+8mzMAQNsONZ wylqq1huuwGkLMzNIZusWWuoIpaHO7O+M4gOfTWqFbrXSyLBQbzeiIHv4gDWjdvt Jgj+lpDwcr+ARbykt7PcydhZ5ggvQZqKJLaOrdg9IJpf6dF1dJFlP5EuW/bTXHKv uZ+NRr8HOvuaxiLJ8DO5PayGFXfpAFmsnIoy8/Eh7b1oQsbntIgDwQF8xbXFwRcT i95mv8ZHdpx8YaSO2pIHmNkGy+10WEmfpQGIaHYnLskVwRSUXqnEIzOmrG8jGkrR DI96YA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=eLUiqZik8J60s5XUBVbGRXtjCxh7z7KsWeVPgokgy iI=; b=hiXr753X7quKIagX0rwPCE+exlFbky7eP7iK12W2JYrK1LVSgVX0PTa+N pMcXWlY+tht8wO6YFzx1zArXQRJ435LNJ9KFpiuYOgzPYxAMgFeh/o4ev7Jj/DdK HX0pwfKlo26DEGZJ9Q7usY6HK6ZWxVIcczN6Ci3jnzpP2aCv2MFxaLQT3/fUdG5q oeFJfI704AAvbofQgXgXnI4tPxA0CcrXpsVo1Y2/X+GMaE76zHaGr8wmaeDScHbx DnJqM7QYRup2iR1tYuRCGL+TmTgSOhYrCuArhXN3Xu/X0T0Clx74FpeOXtiMV6hq E9N/4t9qlb2BNv0HqZXcgwUJUzhLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtledguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8677D328037B; Fri, 6 Nov 2020 12:30:14 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Date: Fri, 06 Nov 2020 18:30:13 +0100 Message-ID: <6977962.WtLBZmdrUi@thomas> In-Reply-To: <2994887.5P9aRgmb0G@thomas> References: <20201105110728.220957-1-bruce.richardson@intel.com> <20201106170105.GA286@bricha3-MOBL.ger.corp.intel.com> <2994887.5P9aRgmb0G@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/1] devtools: test 32-bit build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/11/2020 18:11, Thomas Monjalon: > 06/11/2020 18:01, Bruce Richardson: > > On Fri, Nov 06, 2020 at 05:56:10PM +0100, Thomas Monjalon wrote: > > > From: Bruce Richardson > > > > > > It's reasonably common for patches to have issues when built on 32-bits, so > > > to prevent this, we can add a 32-bit build (if supported) to the > > > "test-meson-builds.sh" script. The tricky bit is using a valid > > > PKG_CONFIG_LIBDIR, so for now we use two common possibilities for where that > > > should point to in order to get a successful build. > > > > > > Signed-off-by: Bruce Richardson > > > Signed-off-by: Thomas Monjalon > > > --- > > > v3: unset override > > > move and rename override > > > split command in check_cc_flags > > > use check_cc_flags for x86 default build > > > v2: added separate flag checking function > > > added override of the DPDK_TARGET value > > > added /usr/lib32 as possible 32-bit libdir > > > --- > > > devtools/test-meson-builds.sh | 32 +++++++++++++++++++++++++++++--- > > > 1 file changed, 29 insertions(+), 3 deletions(-) > > > > > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > > > index a87de635a2..ac76c2184b 100755 > > > --- a/devtools/test-meson-builds.sh > > > +++ b/devtools/test-meson-builds.sh > > > @@ -43,6 +43,12 @@ default_cppflags=$CPPFLAGS > > > default_cflags=$CFLAGS > > > default_ldflags=$LDFLAGS > > > > > > +check_cc_flags () # ... > > > +{ > > > + echo 'int main(void) { return 0; }' | > > > + cc $@ -x c - -o /dev/null 2> /dev/null > > > > Minor nit, as a continuation of the previous line, I think this should be > > further indented. > > In general I keep piped commands at the same level. > This is a matter of taste, > but I can see other piped commands indented in this file, > so I will indent this one as well. > > > Otherwise all looks good to me. Thanks for the updated changes. > > Then I will merge it with above change. I guess we won't get more reviews. Applied