Re: [dpdk-dev] [PATCH] ring: cleanup file-local macros at end-of-file

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-03-03 16:38, Bruce Richardson:
> The ENQUEUE_PTRS and DEQUEUE_PTRS macros defined in rte_ring.h are
> not meant to be global and are not prefixed with the RTE_ prefix.
> Therefore undef the macros at end of file to avoid pollution of the
> global namespace, in case ends apps end up wanting to reuse those names.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  lib/librte_ring/rte_ring.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
> index bdf69b7..0d35648 100644
> --- a/lib/librte_ring/rte_ring.h
> +++ b/lib/librte_ring/rte_ring.h
> @@ -1232,6 +1232,10 @@ rte_ring_dequeue_burst(struct rte_ring *r, void **obj_table, unsigned n)
>  		return rte_ring_mc_dequeue_burst(r, obj_table, n);
>  }
>  
> +/* undef un-prefixed macros which are local to this file */
> +#undef ENQUEUE_PTRS
> +#undef DEQUEUE_PTRS
> +

Thanks for trying to clean-up things.
Note that if an application is using this macro name, it will be destroyed
when including rte_ring.h.
Globally, DPDK namespace is awful and I hope we will be able to improve it.