From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DBFEA0562; Wed, 14 Apr 2021 19:41:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18E42161BF8; Wed, 14 Apr 2021 19:41:34 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 9C8FF4013F for ; Wed, 14 Apr 2021 19:41:31 +0200 (CEST) IronPort-SDR: dwP5PCHgmsw4nmOOTOcYyJ1F7mLY68kdYHT/KUOL+1QJosaVo4KcxsIqYgYcDSt+JoxmYsWZ42 +8SyO9wpfJqQ== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="174194443" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="174194443" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 10:41:30 -0700 IronPort-SDR: ifTU/r9oSfZsaaJYzJWt6hmZMliLKNxue5Lw42spERrFxk6yOx1KuOAuDUzXvKAYIHOPVoVNVj aE2zwRUZrw1g== X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="461304091" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.205.34]) ([10.213.205.34]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 10:41:29 -0700 To: "Min Hu (Connor)" , dev@dpdk.org References: <1618314611-47978-1-git-send-email-humin29@huawei.com> <1618314611-47978-11-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <698abc7a-8c81-de22-7b20-7c2526ec3391@intel.com> Date: Wed, 14 Apr 2021 18:41:24 +0100 MIME-Version: 1.0 In-Reply-To: <1618314611-47978-11-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 10/12] net/hns3: rename Rx burst API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/13/2021 12:50 PM, Min Hu (Connor) wrote: > From: Chengwen Feng > > Currently, user could use runtime config "rx_func_hint=simple" to > select the hns3_recv_pkts API, but the API's name get from > rte_eth_rx_burst_mode_get is "Scalar" which has not reflected "simple". > > So this patch renames hns3_recv_pkts to hns3_recv_pkts_simple, and > also change it's name which gets from rte_eth_rx_burst_mode_get to > "Scalar Simple" to maintain conceptual consistency. > > Also changes the hns3_recv_scattered_pkts API's name which gets from > rte_eth_rx_burst_mode_get to "Scalar". > > Fixes: 521ab3e93361 ("net/hns3: add simple Rx path") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) <...> > @@ -2743,10 +2745,10 @@ hns3_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, > eth_rx_burst_t pkt_burst; > const char *info; > } burst_infos[] = { > - { hns3_recv_pkts, "Scalar" }, > - { hns3_recv_scattered_pkts, "Scalar Scattered" }, > - { hns3_recv_pkts_vec, "Vector Neon" }, > - { hns3_recv_pkts_vec_sve, "Vector Sve" }, > + { hns3_recv_pkts_simple, "Scalar Simple" }, > + { hns3_recv_scattered_pkts, "Scalar" }, > + { hns3_recv_pkts_vec, "Vector Neon" }, > + { hns3_recv_pkts_vec_sve, "Vector Sve" }, No concern on the burst function rename, that is driver internal, but related to the above change, I think new value "Scalar Simple" is not clear, what does 'Simple' mean? At least previously "Scalar Scattered" vs "Scalar" was more clear, one can easily say difference is scattered Rx support, but with "Scalar" vs "Scalar Simple" the difference is not clear.