From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 6FB2DBDC2 for ; Thu, 4 Jun 2015 11:50:41 +0200 (CEST) Received: by wgme6 with SMTP id e6so29277804wgm.2 for ; Thu, 04 Jun 2015 02:50:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ZIaSI2jA4IWch6WQYVAFOoF71Hjpn5bsfWSQWYXQWl0=; b=Cbgra+m5W6tE/S9MIir4HkiyYUg8VrJgvyJEEkdSY0ubYzEDr+n+igY8hezrAHzXZ3 56qO1zsXlVX2mjTwYDgPX7YZPOsNEVuH3H9dlbbvOzOLu1tbCCjp8RJvS3X2ZPvHuO9a xF/pOU362w42Z62LqcUcRLmyPywAkLvHujNf1LihFuJ8W5OuaqNo5xT/YH+7H/N1pYA3 79kdNOSRaaHFwRkoHRkfdIS1ak+nzrRCHyGTmjfYMF8ise27DFMWFv1wHqwSQ49RmTx0 j+R5ywZHQEEIC6lAKfG6fsKSsxKYJGTdBL84h+PqSOLCAr8OHAMdnjghdUCEccAm6oYQ IdvQ== X-Gm-Message-State: ALoCoQkfF3kSG8X0P80WKC/YASESPYWwsqdVFJsb3xi90C8DUU96K3YDMZHZYZOGALt1zFLtVzJm X-Received: by 10.180.90.73 with SMTP id bu9mr50282428wib.88.1433411441328; Thu, 04 Jun 2015 02:50:41 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id xy5sm4952347wjc.35.2015.06.04.02.50.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 02:50:40 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Thu, 04 Jun 2015 11:49:49 +0200 Message-ID: <6992797.Cr2pidrT3F@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150604093330.GA4968@bricha3-MOBL3> References: <1431531022-29697-2-git-send-email-bruce.richardson@intel.com> <1627508.1SMo23WCxz@xps13> <20150604093330.GA4968@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] doc: add coding standards documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2015 09:50:41 -0000 2015-06-04 10:33, Bruce Richardson: > On Wed, Jun 03, 2015 at 07:35:32PM +0200, Thomas Monjalon wrote: > > 2015-06-03 14:58, Bruce Richardson: > > > Add coding standards document to guides directory. This document > > > codifies the current DPDK C coding conventions, to make it easier for > > > contributors to see the format their code should be in. > > > > > > Signed-off-by: Siobhan Butler > > > Signed-off-by: Bruce Richardson > > > > > > --- > > > > > > Updates in V2: > > > * Fixed file creation mode > > > * Removed blank line at end of file > > > * Adjusted coding blocks to be C language, rather than console, so as to > > > have correct syntax highlighting. > > > * Shortened longer lines by breaking lines at sentence - and > > > occasionally comma - boundaries. > > > --- > > > doc/guides/coding_standards/index.rst | 861 ++++++++++++++++++++++++++++++++++ > > > doc/guides/index.rst | 1 + > > > > This version seems very good. > > However, I have the feeling that coding_standards/ is not a good name: > > - "standards" word is a bit strong ; > > - "coding" seems too restrictive, maybe we would like to put > > more guidelines in this directory (thinking about file tree, compat and tests). > > Do you agree I rename it to guidelines/coding_style.rst? > > No problem, go with it! Acked-by: Thomas Monjalon Applied, thanks