From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C19611B3A3
 for <dev@dpdk.org>; Thu, 12 Jul 2018 21:13:28 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 69AB52234A;
 Thu, 12 Jul 2018 15:13:28 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 12 Jul 2018 15:13:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=7C9pARIbgSyU+yX87s2yzz2ePF
 CInLV23HbkAfg/TC8=; b=QetncsPnOgG7yYFaE1YHkVzyzQE2v8LhSZv/YppLu/
 yGQH86S3loy5teNcRR2JMsg3ZDyveXU5H3YvX/IWla+q5mlTBKGNZs46fHlaMXXh
 A3NLK2qo/mezXB4PTcIgeIa+fFs+3+pFsRmQZ0FxkNteur1RbcyaZjNMo0OpM2VY
 4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=7C9pAR
 IbgSyU+yX87s2yzz2ePFCInLV23HbkAfg/TC8=; b=JvX2LsQ7Ej7aYat5ayV6w6
 /uCJgn244QU+J+4I7g5aOWAVN9Mkf4ilvi2dGy/URaRTzNJ+FkUCOk14Ijytith2
 oX122DJKXmlhqaRnOyr2KOAeG1PlSXXshrc/9HnyduSg7q1l7JwZAYQ9tsh/1dAT
 c+5qZ+PhX7tQ74Bv4KjhpsxYtwWTUGoDLAdZyAWRISA8K7H8iGzzDL6tm3OsbB+h
 M4SdnjVfUDRmz0xD4w+BGiv24GY4Bca1K0weLZt70VkX8bV3D07DzIhRUNyYU4NU
 47ZZ8b9rVArZTxYSx7K9OTMfjtyG15tJZ28wS72fV9+9sfMC+oN8Ny+vpaCjRUsw
 ==
X-ME-Proxy: <xmx:WKhHW1ESHncBPIqcBVqRrWKV6HBK4Pji4qn5zFcku0L97fO3WKfT-A>
 <xmx:WKhHW62Yzo82EAKQEhX_85EM722ln2865cd0368KNTzlCXpvvHteAg>
 <xmx:WKhHW4pnPjJASRs_Bi367UwSZ5Cq7nqmB_L5I1v9e2HrVGiVNPZU0Q>
 <xmx:WKhHWzxwFrtbvAahLMgk1CNJOU8f4M-TO3IJym4ES-SvM-ixXwBTow>
 <xmx:WKhHW-tl3OMB5euGKJP0OxkBeBH1RtzcF62YJF55SwYm1HqSAkdDeg>
 <xmx:WKhHW6vjewgA6yCyv3xrc4xOfGhPnywIdClrhWq7JR1yG-WAYUmiOQ>
X-ME-Sender: <xms:WKhHW7Ec2WLM58npU0KJdS22E7rlC1zxB0-y0uMSoxmdUee3y23Ysw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 7A2DC1026C;
 Thu, 12 Jul 2018 15:13:27 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org
Date: Thu, 12 Jul 2018 21:13:26 +0200
Message-ID: <6993574.EjTxxvdgkU@xps>
In-Reply-To: <20180626092317.11031-4-david.hunt@intel.com>
References: <20180621132414.39047-2-david.hunt@intel.com>
 <20180626092317.11031-1-david.hunt@intel.com>
 <20180626092317.11031-4-david.hunt@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 3/9] examples/vm_power: add oob monitoring
	functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jul 2018 19:13:29 -0000

26/06/2018 11:23, David Hunt:
> +#include <unistd.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <signal.h>
> +#include <errno.h>
> +#include <string.h>
> +#include <sys/types.h>
> +#include <sys/epoll.h>
> +#include <sys/queue.h>
> +#include <sys/time.h>
> +#include <fcntl.h>
> +
> +#include <rte_log.h>
> +#include <rte_memory.h>
> +#include <rte_malloc.h>
> +#include <rte_atomic.h>
> +#include <rte_cycles.h>
> +#include <rte_ethdev.h>
> +#include <rte_pmd_i40e.h>
> +
> +#include <libvirt/libvirt.h>
> +#include "oob_monitor.h"
> +#include "power_manager.h"
> +#include "channel_manager.h"
> +
> +#include <rte_log.h>
> +#define RTE_LOGTYPE_CHANNEL_MONITOR RTE_LOGTYPE_USER1

I'm sure you don't need all these headers.
rte_log.h is included twice.
rte_pmd_i40e is more than suspicious...

This is a hint that the whole file was probably written too fast :)