From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41714A034F; Tue, 9 Nov 2021 21:50:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0692B40E03; Tue, 9 Nov 2021 21:50:20 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 2E9E54068B for ; Tue, 9 Nov 2021 21:50:18 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 839BA3201C74; Tue, 9 Nov 2021 15:50:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 09 Nov 2021 15:50:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= OumSsZJeR9IQMmwhGFqmq2jYtsPdhjbcVfwP8zS0xhM=; b=Qx3EOcreEHFnmq+v EKYbgX2i/LPkJIggV2TvyuKsMAsB4hN8511yjQHnV4Zn2It7RmqqgpOMvy9ZkNQc gXnMqLpEvpjnF89nzbarQUk/7ZyguPEukYLDrgNVtZbumCBNB9P0zbX/MZLf1XIa 9wKG/qI48LyHLQAA/fux3qADd/owLynFJ48cgum5BthtleZNDFFyuhKD/uQSShaf S6dF2ZR6qfVlZ/doLAGQLLWAngecqbKNpW6yfYiY4NcrhhZ70Rrkq4ZgpAe32yjl vdfkefbnrkSp7es2W7fyDoPXnPfk8uTqzh5KYfhRoYa6jfbsnALhB/bEny/B89hd UQGJbw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=OumSsZJeR9IQMmwhGFqmq2jYtsPdhjbcVfwP8zS0x hM=; b=cRCgX3sqVsxmBX4hqo0fMHCvFeF5ZFwd6KBSoKfx9hi3TSvototgZMo0f naNLfi6CEQnx0SW2ZJZuRSl31OBIOam2etCVcCDikV/tNlbJ+lkD0xZzYd1836Df BRG2xWT3417AIozZK5wMsfTqY9t6wtpPXHNfzm6fBR+Si4CF6bpUPEam+Lijvt5n 6oJsl1fdljD9ljsZ/7EYtYA+k4S0vgLiL3etb/MDjejTnCb/eYY3GVdXPPDPw/+K ZA67T7hhmc6hnWq8B3OVIxjxjA2cXiAYUOjKhkmZ5v75aYWvIxcwtK+j4Lml+q9A 7jn6a95CEbj0KPpyTr4r+V2hAjd4g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudeggddugeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 9 Nov 2021 15:50:13 -0500 (EST) From: Thomas Monjalon To: Radha Mohan Chintakuntla Cc: fengchengwen@huawei.com, dev@dpdk.org, sburla@marvell.com Date: Tue, 09 Nov 2021 21:50:09 +0100 Message-ID: <6995554.cnLEcGnZd8@thomas> In-Reply-To: <20211109165540.21684-1-radhac@marvell.com> References: <20211109165540.21684-1-radhac@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] usertools/devbind: update octeontx2 DMA device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/11/2021 17:55, Radha Mohan Chintakuntla: > The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver > for the same device uses the dmadev. So this patch updates the device > naming and lists it under dma devices section. > > Signed-off-by: Radha Mohan Chintakuntla > --- > usertools/dpdk-devbind.py | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py > index af9a0ad5ab..e298ad5f75 100755 > --- a/usertools/dpdk-devbind.py > +++ b/usertools/dpdk-devbind.py > @@ -41,8 +41,8 @@ > 'SVendor': None, 'SDevice': None} > octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc', > 'SVendor': None, 'SDevice': None} > -octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081', > - 'SVendor': None, 'SDevice': None} > +cnxk_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081', > + 'SVendor': None, 'SDevice': None} It doesn't look logical to have cnxk device in the middle of octeontx2 ones. Maybe before to sort it a bit alphabetically? > dma_devices = [hisilicon_dma, > - intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx] > + intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx, > + cnxk_dma] Would be better at the beginning of the list, before hisilicon so it is alphabetically sorted.